Repository navigation
Conversation
Restrict PortalFeedbackResult in renderInvoiceDocument to strictly allow
only valid feedback status values ("confirmed" and "disputed") to prevent
unvalidated parameter reflection and UI status spoofing.
Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #251 |
Acknowledged. Thanks for letting me know. |
Summary
feedback) in invoice document view context.?feedback=...on public or private invoice document URLs were stored in template page data without validation, allowing potential UI/status spoofing (displaying "Die Rückmeldung wurde gespeichert." when no feedback was submitted) or oversized query payload reflection.PortalFeedbackResultinrenderInvoiceDocument(internal/server/invoice_document_page.go) to strictly allow only valid feedback status values ("confirmed"and"disputed").TestPortalFeedbackQueryValidationininternal/server/invoice_document_page_test.goand verified the full test suite passes withgo test ./....PR created automatically by Jules for task 10656804699393229424 started by @d0linger