Repository navigation
Conversation
Enforce `yearID <= 0` validation in invoice handlers (`handleInvoiceConfirm`, `handleInvoiceIssue`, `handleInvoiceStorno`, and `handleInvoiceGutschrift`) to reject non-positive year parameters upfront with 400 Bad Request before database store calls. Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Enforce `yearID <= 0` validation in invoice handlers (`handleInvoiceConfirm`, `handleInvoiceIssue`, `handleInvoiceStorno`, and `handleInvoiceGutschrift`) to reject non-positive year parameters upfront with 400 Bad Request before database store calls. Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
Enforce `yearID <= 0` validation in invoice handlers (`handleInvoiceConfirm`, `handleInvoiceIssue`, `handleInvoiceStorno`, and `handleInvoiceGutschrift`) to reject non-positive year parameters upfront with 400 Bad Request before database store calls. Also update workflow Go version references. Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
|
Superseded by #251 |
Understood. Acknowledging that this pull request is superseded and stopping work on this task. |
Enforces non-positive year ID validation (
yearID <= 0) upfront in invoice handlers (handleInvoiceConfirm,handleInvoiceIssue,handleInvoiceStorno, andhandleInvoiceGutschrift) ininternal/server/beleg.go. Also adds unit test coverage ininternal/server/input_limits_test.goto ensure non-positive year IDs return 400 Bad Request.PR created automatically by Jules for task 2383214126087373314 started by @d0linger