Skip to content

🛡️ Sentinel: Reject non-positive year IDs in invoice handlers - #248

Closed
d0linger wants to merge 3 commits into
mainfrom
jules-2383214126087373314-6f39b6c7
Closed

d0linger wants to merge 3 commits into
mainfrom
jules-2383214126087373314-6f39b6c7

Conversation

@d0linger

Copy link
Copy Markdown
Owner

Enforces non-positive year ID validation (yearID <= 0) upfront in invoice handlers (handleInvoiceConfirm, handleInvoiceIssue, handleInvoiceStorno, and handleInvoiceGutschrift) in internal/server/beleg.go. Also adds unit test coverage in internal/server/input_limits_test.go to ensure non-positive year IDs return 400 Bad Request.


PR created automatically by Jules for task 2383214126087373314 started by @d0linger

Enforce `yearID <= 0` validation in invoice handlers (`handleInvoiceConfirm`, `handleInvoiceIssue`, `handleInvoiceStorno`, and `handleInvoiceGutschrift`) to reject non-positive year parameters upfront with 400 Bad Request before database store calls.

Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

google-labs-jules Bot and others added 2 commits October 21, 2026 01:05
Enforce `yearID <= 0` validation in invoice handlers (`handleInvoiceConfirm`, `handleInvoiceIssue`, `handleInvoiceStorno`, and `handleInvoiceGutschrift`) to reject non-positive year parameters upfront with 400 Bad Request before database store calls.

Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
Enforce `yearID <= 0` validation in invoice handlers (`handleInvoiceConfirm`, `handleInvoiceIssue`, `handleInvoiceStorno`, and `handleInvoiceGutschrift`) to reject non-positive year parameters upfront with 400 Bad Request before database store calls. Also update workflow Go version references.

Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
@d0linger

Copy link
Copy Markdown
Owner Author

Superseded by #251

@d0linger d0linger closed this Oct 23, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Superseded by #251

Understood. Acknowledging that this pull request is superseded and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant