PROP-2: proposals are committed at propose time, not created on the implementation branch - #3
Merged
Conversation
…ted-on Implemented by `quantlab implement`. Gates: all passed. Merge is human-only: Daniel merges via PR after Quant Lead review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented through the pipeline itself. See the proposal + implementation report in
docs/proposals/PROP-2-*.mdon this branch.Change:
proposecommits the proposal on the branch it ran from, at propose time, status AWAITING IMPLEMENTATION.implementappends the report and flips the status to IMPLEMENTED on the prop branch only, somainkeeps saying AWAITING until a human merges.--no-commitescape hatch retained.Why: the proposal used to be written untracked and first committed by
implementontoprop/n, so the analysis record lived only on the implementation branch. Observed during the PROP-1 dogfood: rebuildingprop/1destroyed the proposal, which had to be recovered from the remote by hand.Gates: ruff PASS, mypy PASS, pytest 672 PASS. Frontend and verify-dist correctly SKIPPED (no
frontend/path in the diff).Note the bootstrap: PROP-2 was itself created and implemented under the old behaviour — the
implementprocess had already imported the pre-patch module — so its own file is not onmainand its status line still reads AWAITING. The new behaviour is proven by four new tests and takes effect from PROP-3.Depends on #2 (phase-3-pipeline), which carries the pipeline itself.