docs: the CI platform-coupling incident, and required status checks on main - #5
Merged
Conversation
…n main (a) CI found a firewall hole the development platform could not. _normalise built a Path from the raw string, so on POSIX a backslash was part of a filename rather than a separator and config\risk.yaml never matched the frozen config/risk.yaml entry — the firewall ALLOWED it. Passed on Windows, where Path splits on backslash. Live on main from a80ca1d until PR #4, ~15 minutes. Also records the test-reads-gitignored-artifacts anti-pattern, corrected in the same PR. (b) Required status checks added to the main ruleset as a direct consequence: PR #2 merged red. "Requires a PR" and "requires a PR that passes" are different guarantees, and the incident is the proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two decision-log entries, no code.
(a) CI found a firewall hole the development platform could not.
_normalisebuilt aPathfrom the raw string, so on POSIX a backslash was part of a filename rather than a separator:config\risk.yamlnever matched the frozenconfig/risk.yamlentry and the firewall allowed it. The same assertion passed on Windows. Live onmainfroma80ca1duntil PR #4 merged, roughly fifteen minutes. Records the general lesson — a security boundary whose verdict depends on the OS evaluating it is not a boundary, and that class of defect is structurally invisible to the machine it was written on.Also records the test-reads-gitignored-artifacts anti-pattern (
.exists()onreports/*), which passed locally for the wrong reason and failed on a clean checkout. Assert the decision, not the data.(b) Required status checks on
main, as a direct consequence. PR #2 merged red. "Requires a PR" and "requires a PR that passes" are different guarantees; the incident is the proof. Consistent with human-merge-only — this makes merging harder, never automatic.