-
Notifications
You must be signed in to change notification settings - Fork 3
fix: isolate Symphony GitHub token #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−7
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,9 +31,9 @@ explicitly request rework after review. | |
| - Install Git, and configure SSH access that can push to | ||
| `git@github.com:dapi/memory-bank.git`. | ||
| - Install and authorize `direnv` for this repository's `.envrc`. | ||
| - Create a GitHub token with access to this repository's issues and pull | ||
| requests. Symphony uses it to poll the tracker; the agent uses its authenticated | ||
| `gh` CLI for GitHub reads and updates. | ||
| - Provide a GitHub token for Symphony's tracker as `SYMPHONY_GITHUB_TOKEN`. | ||
| If it is absent, `.envrc` uses `gh auth token` for the tracker. The agent | ||
| continues to use its authenticated `gh` CLI for GitHub reads and updates. | ||
| - Install `mise`; the bootstrap script installs the required Elixir/Erlang | ||
| versions. | ||
|
|
||
|
|
@@ -45,9 +45,8 @@ cp .env.local.example .env.local | |
| direnv allow | ||
| ``` | ||
|
|
||
| It expects the GitHub token at `pass:github/homebrew-token`. If the local | ||
| password-store layout differs, change only the ignored `.env.local`; never add | ||
| the literal token to a tracked file. | ||
| Set `SYMPHONY_GITHUB_TOKEN` in the ignored `.env.local`; never add the literal | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Симфони не должна ничего знать про .env* файлы, пользователь должен сам позаботиться об установке переменных окурежния |
||
| token to a tracked file. | ||
|
|
||
| ## Run | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| --- | ||
| tracker: | ||
| kind: github | ||
| provider: | ||
| token: $SYMPHONY_GITHUB_TOKEN | ||
| active_states: | ||
| - open | ||
| terminal_states: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Убери эти исправления. Симфони не должна ничего знать про .env* файлы, пользователь должен сам позаботиться об установке переменных окурежния