chore: bump version to 0.1.8 - #20
Merged
Merged
Conversation
Aligns the in-app version line (RFC 0016, Settings -> Privacy) with the v0.1.8 release tag; versionName had stayed at 0.1.0 since inception, which would have made the displayed version permanently wrong. Signed-off-by: will wade <willwade@gmail.com>
willwade
added a commit
that referenced
this pull request
Aug 22, 2026
Found while cutting v0.1.8: `versionName` had been stuck at "0.1.0" since inception (manually bumped to 0.1.8 in #20). With RFC 0016's version line now shipped, the tag should be the single source of truth. Companion: Dasher-GTK #56 (same treatment via CMake `git describe`). ## Changes (`app/build.gradle.kts`) - `versionName` = most recent `v*` tag via `git describe --tags --match v*` run from the repo root: tag builds report the tag exactly; dev builds report `0.1.8-3-g1a2b3c4`. The literal constants remain only as no-git (tarball) fallbacks. - `versionCode` = **1000 + commit count** (`git rev-list --count HEAD`) — deterministic, strictly monotonic, and above every historically shipped code (max 8). No more manual `versionCode` arithmetic. - `release.yml`: on `v*` tag pushes, the built APK's `versionName` (read via `aapt2 dump badging`) must equal the tag, else the workflow fails **before** publishing — a mislabelled APK can never ship. ## Verified locally - APK badging on this branch: `versionName='0.1.8' versionCode='1060'` (1000 + 60 commits). - Simulated dev commit on top of the tag: describe → `0.1.8-1-g457c264`. - `:app:assembleDebug` green. DCO signed. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-line release bump:
versionName"0.1.0" → "0.1.8",versionCode1 → 8.versionNamehad never been bumped; with RFC 0016's version line now shipping (Settings → Privacy readsBuildConfig.VERSION_NAME), the app would have displayedDasher 0.1.0forever. Aligns with the v0.1.8 tag.DCO signed.