Skip to content

test(dashmate): use a sentinel wake-up counter the clock cannot collide with #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shumkov wants to merge 1 commit into
base: v4.2-dev
Choose a base branch
from
+6 −3
Open

test(dashmate): use a sentinel wake-up counter the clock cannot collide with #4565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/dashmate/test/unit/doctor/analyse/analyseGatewayCertificateFactory.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,10 @@ describe('analyseGatewayCertificateFactory', () => {
detail: 'acme: error: 400 :: urn:ietf:params:acme:error:connection :: timeout',
attemptedAt: new Date(Date.now() - 30 * 60 * 1000).toISOString(),
lastSuccessAt: new Date(Date.now() - 5 * DAY_MS).toISOString(),
consecutiveFailures: 37,
// A sentinel no rendered date or time can contain: the counter-leak
// assertions below match it verbatim, so a coincidental "37" in a
// minute field can no longer fail them.
consecutiveFailures: 739577,
issuanceSpentAt: null,
issuanceUncertainAt: null,
gatewayReloadFailedAt: null,
Expand Down Expand Up @@ -912,8 +915,8 @@ describe('analyseGatewayCertificateFactory', () => {
expect(renewal.getDescription()).to.not.contain('failing since');
expect(renewal.getSolution()).to.not.contain('failing since');
// The counter counts scheduler wake-ups, not attempts.
expect(renewal.getDescription()).to.not.contain('37');
expect(renewal.getSolution()).to.not.contain('37');
expect(renewal.getDescription()).to.not.contain('739577');
expect(renewal.getSolution()).to.not.contain('739577');
});

it('should name the cause instead of sending an operator to the logs', () => {
Expand Down
Loading