Skip to content

perf(drive-abci): don't read every withdrawal document to build a debug log line #4569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PastaPastaPasta wants to merge 1 commit into
base: v4.2-dev
Choose a base branch
from
Open

perf(drive-abci): don't read every withdrawal document to build a debug log line #4569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .../execution/platform_events/withdrawals/pool_withdrawals_into_transactions_queue/v1/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ where
.withdrawal_transactions_per_block_limit,
"No queued withdrawal documents found to pool into transactions"
);
// Reading every withdrawal document the chain ever produced, only to
// count them for a log line. Withdrawal documents are never removed,
// so this grows without bound with chain history — measured at 4.8 ms
// a block by height 200,000 on mainnet, and it ran on every block
// that had nothing queued, which is nearly all of them. Do it only
// when the line it feeds will actually be emitted.
if !tracing::enabled!(tracing::Level::DEBUG) {
return Ok(());
}

let all_documents = self
.drive
.fetch_oldest_withdrawal_documents(transaction, platform_version)?;
Expand All @@ -57,7 +67,7 @@ where
height = block_info.height,
"No withdrawal documents found at all"
);
} else if tracing::enabled!(tracing::Level::DEBUG) {
} else {
// Count documents by status
let queued_count = all_documents
.get(&(withdrawals_contract::WithdrawalStatus::QUEUED as u8))
Expand Down
Loading