docs(wasm-sdk): clarify aggregate groupBy behavior - #4576
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughUpdated ChangesAggregate query documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only corrects documentation wording for existing aggregate-query behavior, with no runtime or API behavior changes. No actionable merge-blocking risk remains beyond normal review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Ready for review — 11 ahead in queue (commit 12914ce) |
Issue being fixed or feature implemented
The
DocumentsQuery.groupBydeclaration described the option exclusively as a count-query setting, despite the type also being shared by document sum and average queries. This caused generated declaration-based documentation to show count-specific wording for those methods.What was done?
DocumentsQuery.groupByJSDoc inpackages/wasm-sdk/src/queries/document.rsto describe all aggregate queries.getDocumentsCount,getDocumentsSum, andgetDocumentsAverage.groupByas count-only.How Has This Been Tested?
No build or automated tests were run because this change only updates documentation comments.
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
groupBydocumentation for count, sum, and average aggregate results.