Skip to content

feat(sdk)!: add scoped authentication key SDK support - #4654

Closed
PastaPastaPasta wants to merge 1 commit into
dashpay:feat/scoped-contract-auth-keysfrom
PastaPastaPasta:feat/scoped-contract-auth-sdk
Closed

feat(sdk)!: add scoped authentication key SDK support#4654
PastaPastaPasta wants to merge 1 commit into
dashpay:feat/scoped-contract-auth-keysfrom
PastaPastaPasta:feat/scoped-contract-auth-sdk

Conversation

@PastaPastaPasta

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Applications and wallets must preserve the scoped key permissions enforced by #4613. This PR is stacked on feat/scoped-contract-auth-keys (#4613) and contains the SDK changes only.

What was done?

  • Add native scope ABI fields, marshalling, cleanup, restore, and JNI transport; replace the foundation PR’s unsupported-scope guard with complete scope support.
  • Preserve scopes in Kotlin persistence (Room 11→12), Swift wrappers/key refresh, and WASM construction and serialization APIs.
  • Freeze the V4 SwiftData relationship component and migrate V4→V5 instead of changing V4’s checksum. Existing wallet/key relationships and Keychain references survive, and scope bytes persist across reopening.
  • Add the application integration guide and SDK regression/smoke coverage.

How Has This Been Tested?

Breaking Changes

Native libraries, generated headers, and Swift/Kotlin consumers must update together because public-key FFI layouts gain scope fields. Existing stores migrate with Room 11→12 and SwiftData V4→V5. Merge #4613 first; protocol-14 activation is required to register/use scoped keys.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

This pull request was created by Codex.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5d2e0f0c-57da-4031-aa91-07c017ea8343

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 9th in line, estimated start in ~1.2 h (commit 4345770)
Estimated review time once started: ~15 min (two-phase automated review; median of recent runs).

  • Request priority review — tick this box and the review moves to the front of the queue.

@PastaPastaPasta

PastaPastaPasta commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Superseded by #4655, which uses the dashpay/platform head branch.


🤖 Posted autonomously by Codex on behalf of pasta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants