Conversation
Factor the fetch-bundles-then-write-each-skill core (with the per-skill fetch failure and disk error skip) out of _download_refs and reconcile_managed_skills into a single _fetch_bundles_and_write helper. Pure refactor: the download path gains the same per-skill OSError guard the managed reconcile already had. Co-authored-by: Isaac <no-reply@databricks.com>
xsh310
added this pull request to stack #765
September 20, 2026 01:24
xsh310
changed the title
This was referenced Sep 20, 2026
xsh310
marked this pull request as ready for review
September 20, 2026 04:18
xsh310
removed this pull request from stack #765
September 20, 2026 19:21
xsh310
added this pull request to stack #768
September 20, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you change, and why?
Change: Extracted the fetch-bundles-then-write-each-skill core (with the per-skill fetch-failure and disk-error skip) out of
_download_refsandreconcile_managed_skillsinto a single_fetch_bundles_and_writehelper inskills_download.py.Why: The two callers had duplicated this loop, and a third caller, a launch-time skill refresh stacked on top in #764, needs the same core. Sharing one helper keeps them consistent. This is a pure refactor with no behavior change, except that the download path now gains the same per-skill
OSErrorguard the managed reconcile already had.How do you know it works?
Testing: The existing
_download_refsandreconcile_managed_skillstests still pass, plus a newTestFetchBundlesAndWritecovering the write-survivors, skip-fetch-failure, and empty-refs cases.uv run ruff check,ruff format --check,ty check src, anduv run pytestall pass locally.This pull request and its description were written by Isaac.
Stack created with GitHub Stacks CLI • Give Feedback 💬