India_LifeExpectancy | Added_goldens - #2109
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces validation configuration and golden data files for the India NDAP Life Expectancy import. Specifically, it adds validation_config.json with rules for deleted records percentage and golden data checks, updates manifest.json to reference this configuration, and provides the corresponding golden observation and summary report CSV files. Feedback is provided regarding the Wikidata ID used for Delhi in the golden observations, which should be updated to Q9357528 instead of Q1353 to match the repository's mapping rules for Indian administrative data at the AA1 level.
|
Pls add import name in PR title |
Added output counters to the script execution command and updated source files list.
2 participants
Jobs ran successfully. Added Golden Checks.
Files added are : golden_data/, manifest.json, validation_config.json