NewYorkUniversity_Diabetes - cron schedule added - #2120
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the manifest for the New York diabetes import by adding a cron schedule and specifying resource limits for CPU, memory, and disk. The feedback suggests specifying the memory and disk limits as strings with standard units (e.g., "8G" and "100G") instead of plain integers to avoid potential out-of-memory errors or schema validation failures in Kubernetes environments.
| "resource_limits": { | ||
| "cpu": 4, | ||
| "memory": 8, | ||
| "disk":100 | ||
| } |
There was a problem hiding this comment.
In GKE/Kubernetes environments, resource limits for memory and disk are typically specified as strings with units (e.g., "8G" or "8Gi", "100G" or "100Gi"). Specifying them as plain integers can lead to them being interpreted as bytes (which would cause immediate Out-Of-Memory errors or scheduling failures) or fail schema validation. Please update them to use standard unit strings.
| "resource_limits": { | |
| "cpu": 4, | |
| "memory": 8, | |
| "disk":100 | |
| } | |
| "resource_limits": { | |
| "cpu": 4, | |
| "memory": "8G", | |
| "disk": "100G" | |
| } |
Import name =
NewYorkUniversity_DiabetesPR checklist = Doc
Overview
Updated manifest.json with cron schedule
Key Changes