Skip to content

NewYorkUniversity_Diabetes - cron schedule added - #2120

Open
goutamabrol wants to merge 2 commits into
datacommonsorg:masterfrom
goutamabrol:us_nydiabetes
Open

NewYorkUniversity_Diabetes - cron schedule added#2120
goutamabrol wants to merge 2 commits into
datacommonsorg:masterfrom
goutamabrol:us_nydiabetes

Conversation

@goutamabrol

Copy link
Copy Markdown

Import name = NewYorkUniversity_Diabetes
PR checklist = Doc

Overview

Updated manifest.json with cron schedule

Key Changes

  • Missing cron schedule in the manifest.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the manifest for the New York diabetes import by adding a cron schedule and specifying resource limits for CPU, memory, and disk. The feedback suggests specifying the memory and disk limits as strings with standard units (e.g., "8G" and "100G") instead of plain integers to avoid potential out-of-memory errors or schema validation failures in Kubernetes environments.

Comment on lines +36 to +40
"resource_limits": {
"cpu": 4,
"memory": 8,
"disk":100
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In GKE/Kubernetes environments, resource limits for memory and disk are typically specified as strings with units (e.g., "8G" or "8Gi", "100G" or "100Gi"). Specifying them as plain integers can lead to them being interpreted as bytes (which would cause immediate Out-Of-Memory errors or scheduling failures) or fail schema validation. Please update them to use standard unit strings.

Suggested change
"resource_limits": {
"cpu": 4,
"memory": 8,
"disk":100
}
"resource_limits": {
"cpu": 4,
"memory": "8G",
"disk": "100G"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant