Skip to content

Eliminate hardcoded project names for integration tests - #2285

Merged
apilaskowski merged 2 commits into
mainfrom
integration-tests-config
Sep 8, 2026
Merged

Eliminate hardcoded project names for integration tests#2285
apilaskowski merged 2 commits into
mainfrom
integration-tests-config

Conversation

@Ford544

@Ford544 Ford544 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Replace hardcoded references to the default dataform-open-source project with a constant in cli/index_test_base, set based on the contents of test_credentials/bigquery.json if exists, and the defaults (dataform-open-source, US location) otherwise.

Update the Integration Test section of contributing.md.

@Ford544
Ford544 requested a review from a team as a code owner September 7, 2026 12:55
Comment thread cli/index_test_base.ts
Comment thread cli/tests/jit/index_jit_dependency_test.ts Outdated
Comment thread tests/integration/bigquery.spec.ts
Comment thread tests/integration/bigquery.spec.ts Outdated
Comment thread contributing.md Outdated
Comment thread contributing.md
Comment thread cli/index_test_base.ts Outdated
Comment thread cli/index_test_base.ts Outdated
Comment thread cli/index_test_base.ts Outdated
Comment thread tests/integration/bigquery.spec.ts Outdated
Comment thread cli/index_test_base.ts Outdated
Comment thread cli/index_test_base.ts Outdated
Comment thread tests/integration/bigquery.spec.ts Outdated
@Ford544
Ford544 force-pushed the integration-tests-config branch from 1d2e953 to cd5eeda Compare September 8, 2026 09:34
@Ford544
Ford544 enabled auto-merge (squash) September 8, 2026 14:35
@Ford544
Ford544 disabled the stack merge September 8, 2026 15:01
…ect with

a constant in cli/index_test_base, set based on the
contents of test_credentials/bigquery.json if exists, and the default
otherwise.

Updated the Integration Test section of contributing.md.
…ls/BUILD to dynamically select credentials based on the presence of bigquery.json file. Updated contributing.md
@Ford544
Ford544 force-pushed the integration-tests-config branch from cd5eeda to ccf63f5 Compare September 8, 2026 15:04
@apilaskowski
apilaskowski merged commit 11a8d04 into main Sep 8, 2026
11 checks passed
@apilaskowski
apilaskowski deleted the integration-tests-config branch September 8, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants