Skip to content

Check Cargo.lock into version control? #64

Closed

Description

@backkem

Right now Cargo.lock is gitignored, so CI resolves fresh on every run. Hit a case where that bit us:

datafusion-federation = "0.5.5" is a caret req, so a fresh resolve grabbed 0.5.6, which wants datafusion = "55" while we're on 54. Cargo happily built both trees and datafusion-flight-sql-table-provider stopped compiling. Nothing in the repo changed, just an upstream release. #62 works around it with =0.5.5, #63 does the real 55 bump.

So — worth checking the lockfile in? Would make CI reproducible, and it doesn't affect downstream consumers either way, only Cargo.toml does that.

Flip side: it'd also hide upstream drift, so we'd stop catching this kind of thing from normal CI. A scheduled unlocked run would cover that.

No strong opinion either way, just curious what folks prefer. If we do it, CI should probably pass --locked.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions