Repository navigation
feat(prs): mark r as the key that runs a review round - #107
Merged
Merged
Conversation
prs reads a window action's runs_review_round to know which window runs a Claude review round, and shows the row as claude running while that window is open and the round has not finished. prs releases before this tracks it, since a prs without the field refuses the whole config. Agent-Name: claude-code-unattended Agent-Session: e999b398-dbff-4616-bec4-8a433b70f632 Agent-Run: 01a1ba02-f445-7d6e-ae62-ae0826bc7073 Worklog: 1329.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prs reads a window action's
runs_review_roundto know which tmux window runs a Claude review round. Without it onr, a round started from prs reads nothing on its row until its first reviewer posts, about four minutes on prs PR 7's round. This marksrin the prs config template.Merge this only after datapointchris/prs#11 merges and its release is out. Every prs before that release refuses the whole config with
field runs_review_round not found in type config.WindowAction, soprs tuiwould not start on any box that applies this first.What to look at
configs/common/.config/prs/config.yml.tmpl: one key on theraction, and the comment above it.How it was verified
prs#11's build reads the rendered template as
key r claude review offered, runs review roundsunderprs config show. The installed prs refuses it with the error above, which is the ordering this PR waits on. The commit hooks passed.What changes
After the next
dotfiles apply, a row whoserwindow is open readsclaude runninguntil a round finishes after the window opened.Risk and rollback
Applied before prs's release, prs refuses its config on that box until the release installs. A revert of this file alone restores it.
Session e999b398-dbff-4616-bec4-8a433b70f632.