Repository navigation
feat(prs): name the recaps tab's list, show and write commands - #108
Merged
Merged
Conversation
prs draws a recaps tab from three commands its config names. These run fleet's ledger recaps: list prints each window recorded over 90 days, newest first, show prints one window's recap, and write dispatches one with a model call. needs keeps the tab off a machine without fleet or jq, which the same template reaches. The list runs through sh with pipefail, because fleet failing ahead of jq would otherwise exit 0 with nothing printed, which the tab reads as no recap written. prs refuses a config key it does not know, so this lands only once the prs release that reads recaps is out. Agent-Name: claude-code-unattended Agent-Session: 7e57e57e-0638-4af5-be9f-487326ef59f6 Agent-Run: 01a1bc01-a281-7515-9483-0ecb8a28f7c5 Worklog: 1333.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prs draws a recaps tab only where its config names the commands behind it, so until this lands the tab never shows on any machine. This names the three commands in prs's config template:
listprints each window recorded over the last 90 days as<kind> <label>, newest first,showprints one window's recap, andwritedispatches one with a model call.What to look at
configs/common/.config/prs/config.yml.tmpl, therecapsblock.needs: [fleet, jq]keeps the tab off a machine the same template reaches without them, because the list runs throughsh -cand hides both from prs.listscript'sset -o pipefail. Without it, fleet failing ahead of jq exits 0 with nothing printed, and the tab reads that as no recap written.How it was verified
The template was rendered with
REPOS_REGISTRYfilled, and loaded by the prs binary built from datapointchris/prs#16:Without
pipefail, the list run with fleet's daemon unconfigured printed fleet's error on stderr and exited 0. With it, the same run exited 1.What changes
prs tuigains a recaps tab on every machine with fleet and jq, after the nextdotfiles apply.Risk and rollback
prs 0.15.0 and earlier refuse a config key they do not know, and this adds
recaps:So this merges only once the prs release carrying datapointchris/prs#16 is installed. A revert removes the block, and the tab with it.
Session 7e57e57e-0638-4af5-be9f-487326ef59f6