feat(enclave): pin permission on dr enclave permission grant/revoke/list - #930
Draft
alexromanyuk wants to merge 1 commit into
Draft
alexromanyuk wants to merge 1 commit into
alexromanyuk wants to merge 1 commit into
Conversation
Adds "pin" as a second collection-level enclave permission next to "create": the right to pin a workload to one chosen enclave (dr workload create --enclave <name>), overriding the scheduler's placement. Pinning stays separate from deploy access - the pinned enclave must still be allowed by the workload's use case, and deploy access to it is still required. Create implies pin, so revoking pin from a create holder is refused server-side; revoke create instead. The wire stays compatible with servers that predate pin: the permission field and query parameter are omitted for "create", so existing create grants and listings are byte-for-byte unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
pinas a second collection-level enclave permission next tocreate: the right to pin a workload to one chosen enclave (dr workload create --enclave <name>), overriding the scheduler's placement.dr enclave permission grant --permission pin --user-id <id>(also--group/--org)dr enclave permission revoke --permission pin ...dr enclave permission list --permission pinshowand help texts describe both permissions.Semantics
dr enclave access grant).createimpliespin. Revoking pin from a recipient who holds create is refused server-side - revoke create instead.Compatibility
The
permissionbody field and query parameter are omitted forcreate(the server default), so requests against servers that predate pin are byte-for-byte unchanged;--permission pinagainst such a server is refused server-side.Draft: pairs with the server-side change that registers the pin permission; do not merge before it ships.