You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make Private DNS permissions and enablement safe for rollout #691
NetworkContext.spec.dns carries nameservers, searches and accessBindingRef. The runbook says to allow only trusted controllers to write it, but no ValidatingAdmissionPolicy enforces that.
config/rbac/role.yaml grants write on dnsresolvercontexts, dnsresolveraccessbindings and galactic serviceendpoints and serviceroutepolicies unconditionally. The runbook notes that a runtime flag does not revoke RBAC.
go.mod pins go.datum.net/galactic v0.6.3-0.20261021151056-bb0b4c057338. Pin a tag once galactic#851 releases.
An empty spec.dns.mode means Managed once internalDNS.enabled is on. The runbook calls the flag a global switch.
Also: networkBindingRequestsForContext now lists bindings in every namespace even with the flag off, and the commit deleted the comment above TestACopyLosesALabelItsSourceDropped.
The description now explains the problem and expected outcome in plain language. The original report is preserved below for the observations, diagnostics, and implementation details behind this work. It describes the situation when the issue was reported; later comments and the issue state record subsequent progress.
changed the title [-]Internal DNS for networks: unenforced writes, broad permissions, branch pin[/-][+]Make Private DNS permissions and enablement safe for rollout[/+]on Oct 29, 2026
Activity
ecv commentedon Oct 22, 2026
Detail, as of #631 at 2b967ea:
NetworkContext.spec.dnscarries nameservers, searches andaccessBindingRef. The runbook says to allow only trusted controllers to write it, but no ValidatingAdmissionPolicy enforces that.config/rbac/role.yamlgrants write ondnsresolvercontexts,dnsresolveraccessbindingsand galacticserviceendpointsandserviceroutepoliciesunconditionally. The runbook notes that a runtime flag does not revoke RBAC.go.modpinsgo.datum.net/galactic v0.6.3-0.20261021151056-bb0b4c057338. Pin a tag once galactic#851 releases.spec.dns.modemeans Managed onceinternalDNS.enabledis on. The runbook calls the flag a global switch.Also:
networkBindingRequestsForContextnow lists bindings in every namespace even with the flag off, and the commit deleted the comment aboveTestACopyLosesALabelItsSourceDropped.scotwells commentedon Oct 29, 2026
The description now explains the problem and expected outcome in plain language. The original report is preserved below for the observations, diagnostics, and implementation details behind this work. It describes the situation when the issue was reported; later comments and the issue state record subsequent progress.
Original report and engineering evidence
Internal DNS for networks, from Enable private DNS resolution for networks, ships with four loose ends that did not block the review.
Done when each is enforced, released or documented as accepted. The detail is in the first comment.
Related to Enable private DNS resolution for networks
[-]Internal DNS for networks: unenforced writes, broad permissions, branch pin[/-][+]Make Private DNS permissions and enablement safe for rollout[/+]