Repository navigation
fix: Register field indexers in the cell manager - #510
Merged
Merged
Conversation
The cell controller manager never called controller.AddIndexers, so networkInterfaceClaimNetworkIndex was registered on the standalone manager binary but not here. Every NetworkContext event on a cell then failed to list its NetworkInterfaceClaims with "index ... does not exist", so no cell ever finished a claim reconcile once a network context changed after startup. Add the same AddIndexers call the manager binary already makes, right after controller setup, so both binaries register the same indexes.
privateip
marked this pull request as ready for review
September 27, 2026 13:40
privateip
enabled auto-merge
September 27, 2026 13:42
scotwells
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A cell's own claim reconciler lists NetworkInterfaceClaims by a field index that only the standalone manager binary registers at startup. The cell binary never made that call, so every NetworkContext change on a cell failed the list with "index does not exist" and never recovered on its own, no matter how many times the cell restarted.
The practical effect: once a network's context changed after a cell first started, new interfaces on that network stopped getting the routes and neighbor entries their reconcile installs, with no error surfaced anywhere near the affected workload.
This adds the same indexer registration call the manager binary already makes, right after the cell sets up its own controllers.
Test plan
make testandmake lintpass