Skip failed load balancer deletions in activity timelines - #516
Merged
Merged
Conversation
scotwells
marked this pull request as ready for review
September 28, 2026 19:03
ecv
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed load balancer deletion must not appear in the customer's timeline as a successful deletion. Generate delete activity only for successful responses, and tolerate responses without metadata so failed requests do not repeatedly fail policy evaluation.
For HTTPProxy DELETE events,
audit.responseStatus.codemust be in the 200–299 range. For example, an HTTP 500 response without a body produces no deletion entry; an HTTP 200 response without annotations still produces the existing resource-name or generic deletion summary. No policy labels or new configuration are required.This addresses the two HTTP 500 DELETE events remaining in staging after five events recovered with #514. The candidate policy skips both retained payloads without errors or misleading deletion entries; they remain queued pending rollout and retry.
Validated eight delete scenarios, a policy render, and read-only evaluation of both staging payloads; CI, including E2E, is green.
Related to https://github.com/datum-cloud/infra/issues/6019.