fix: let domains pointed at Datum verify before their zone goes live - #519
Merged
Merged
Conversation
The DNS operator won't provision a DNSZone until its Domain is verified, so the zone never becomes Programmed. Requiring Programmed for DNSZone verification deadlocked every domain delegated to Datum nameservers. attemptDNSZoneVerification now also accepts a zone that is Accepted=False with reason PendingDomainVerification. It does so only for the registered apex: all zones share nameservers, and a subdomain with no delegation of its own reports its parent's, so accepting one would let any tenant verify sub.example.com once example.com was on Datum. A waiting subdomain zone falls through to TXT or HTTP verification.
mattdjenkinson
approved these changes
Sep 29, 2026
scotwells
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domains pointed at Datum nameservers never verify, because the DNS operator holds a zone back until its domain is verified (datum-cloud/dns-operator#100) and delegation only counted live zones. A waiting zone can now verify its domain, but only a registered domain, since a subdomain reports its parent's shared Datum nameservers and anyone could claim it. Waiting subdomains fall back to the TXT record or HTTP token.
Merge and roll out before datum-cloud/dns-operator#200.
Test plan