chore(deps): upgrade @datum-cloud/datum-ui to 3.4 - #524
Merged
Merged
Conversation
Bump @datum-cloud/datum-ui from ^2.5.0 to ^3.4.0 and motion from ^12 to ^13 to satisfy datum-ui's motion peer range (>=13 <14, required since 2.0.0). The cloud-portal host already supplies datum-ui 3.x for the shared subpaths, so this aligns the local install with what renders at runtime. No source changes are needed: the plugin uses none of the renamed type-scale classes or the Typography components.
JoseSzycho
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
@datum-cloud/datum-uiinui/consumerfrom^2.5.0to^3.4.0, crossing the 3.0.0 type-scale change.ui/consumeris a Module Federation remote. At runtime the cloud-portal host supplies the shared datum-ui subpaths, and the host is already on datum-ui 3.x. So the plugin already renders against 3.x in the portal. This PR brings the local install (used for types, tests and standalone dev) up to the same version. Thesharedconfig invite.config.tsis unchanged, and every shared subpath still resolves in 3.4.Changes
@datum-cloud/datum-ui:^2.5.0→^3.4.0(resolves 3.4.0)motion:^12→^13(resolves 13.4.6). datum-ui has declaredmotion >=13 <14as a peer since 2.0.0, so the old^12was already out of range. The plugin doesn't importmotiondirectly. Motion 13 only drops@emotion/is-prop-valid, which nothing here uses.bun.lockrefreshed. Only datum-ui and the motion family (motion,framer-motion,motion-dom,motion-utils) changed.Migrations applied
text-2xs→text-5xstext-1xs→text-2xsText/Paragraphsize="base"→size="sm"Text/Titlecolour inheritance (textColor="default")package.json)I searched all
.ts/.tsxundersrc/,cn()strings and template literals. There are no.cssfiles and no Tailwind config: the plugin uses the host's Tailwind build. I found no@tanstack/react-tableusage (the 2.0ColumnDefchange) and no deprecated APIs from the 2.6 to 2.12 minors. No source changes were needed.Visual check
The portal already renders these with 3.x, so nothing should change there. These are the places where 3.x behaves differently from 2.5, for a check in standalone dev and on tablet or mobile widths:
pages/network-list.tsx): theStatTilesvalues usetext-3xl. Since 3.0,xland larger shrink below 1024px. Also check the page title, empty state and table badges.pages/network-detail.tsx): the network nameh1usestext-2xl, so it also shrinks on tablet and mobile. Also check the resource section headings (text-lg, unchanged size) and the Topology popovers.Cardno longer has a default drop shadow.Test plan
bun install --frozen-lockfile(what the Dockerfile runs)bun run typecheck(tsc --noEmit)bun run lint(tsc --noEmit)bun run test: 17 files, 196 tests passbun run build(vite build, the Docker build step)bun run dev: check the screens above against the portal rendering