Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customers can continue publishing Connector health while other networking status endpoints remain reserved for controllers and separately authorized staff once subresource enforcement is enabled. Connector and Network viewers can read Connector status; their admin roles can also update and patch it. Existing access to resource contents, including observed status, stays unchanged.
Declares the 23 status subresources served by the installed CRDs and grants customer status permissions only for Connectors. Checks include inherited Network roles; no viewer gains write access.
Rollout depends on milo-os/milo#824 and milo-os/openfga-provider#139: install the schema and declarations, enable and converge the provider manager, then apply the Connector Role grants and wait for Roles/PolicyBindings to become ready before enabling webhook enforcement. The feature stays off by default; this PR does not enable it. New Connector Role grants must not be applied while the manager feature is off.
Validation: Kustomize builds for protected resources, roles, upstream resources, default deployment, and Milo integration pass. Manifest assertions matched all 26 registrations against served CRDs (23 with status), checked all 9 roles transitively, and confirmed base permissions are unchanged. No cluster changes.