Conversation
4 tasks
scotwells
force-pushed
the
feat/wildcard-admission
branch
from
October 2, 2026 22:13
e44f41d to
806ddf8
Compare
scotwells
force-pushed
the
feat/wildcard-certificates
branch
from
October 2, 2026 22:13
f3e60c6 to
1104b62
Compare
With wildcard admission in place, drive a DNS-proven wildcard through the whole gateway reconcile: the request, the mirror and the listener. The certificate service path no longer answers HTTP-01 for any hostname, so the earlier guard that kept HTTP challenge answers off wildcards is gone; a test keeps the property. Key changes: - request exactly one DNS-01 TLSCertificate for the wildcard and no cert-manager Certificate - answer no HTTP challenge for a wildcard, whatever the status lists - admit the listener once a certificate covering the wildcard is mirrored - refuse a broader wildcard certificate that does not name the listener's wildcard, and a wildcard certificate for a deeper name
scotwells
force-pushed
the
feat/wildcard-admission
branch
from
October 2, 2026 23:35
806ddf8 to
cb9f8c4
Compare
scotwells
force-pushed
the
feat/wildcard-certificates
branch
from
October 2, 2026 23:35
1104b62 to
83190b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wildcard admission and the certificate service each have their own tests, but nothing yet drives a DNS-proven wildcard through the whole flow, from the certificate request to serving it on the edge.
This adds that coverage: one DNS-01 request naming only the wildcard, no HTTP challenge answer ever published for it, the issued certificate applied to the listener, and a certificate for the wrong name refused.
The certificate service no longer answers HTTP challenges for any hostname, so the separate guard this change used to add is gone and a test keeps the property instead.
This is stacked on #530 and changes no behaviour.
API
No API change. A wildcard hostname yields this certificate request in the project:
What the edge serves for the listener:
Test plan
Related to datum-cloud/enhancements#913