test(services): add regression coverage for POST .../create returning real _id - #166
Merged
Merged
Conversation
… real _id Closes #157. The production fix was already live on `staging` since commit f355e2f (2026-08-21) — `baseCreateDocument`'s hookAfterSave result was already propagated correctly — but no regression test ever covered it and the diagram node was never backfilled. - src/__tests__/services/baseCreateDocument.test.ts: direct unit coverage of the hookAfterSave replacement propagation. - src/__tests__/candidate_profile/BaseService.test.ts: spot-checks a real CV section create flow through the unmocked createCrudService/BaseService.ts/services/index.ts code path (only the Mongoose model is faked) — confirms the response's _id is the real persisted id, not null. - agent-hub: backfill evidence (implementer + verifier) and seal node fix-create-response-null-id. npm test: 140 passed, 140 total. npm run build: clean. Node: fix-create-response-null-id (SEALED) Evidence: agent-hub/evidence/implementer/2026-09-28/fix-create-response-null-id-plan.md, agent-hub/evidence/verifier/2026-09-28/fix-create-response-null-id-seal.md Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #157. The production fix was already live on
stagingsince commitf355e2f(2026-08-21) —baseCreateDocument'shookAfterSaveresult was already propagated correctly — but no regression test ever covered it and the diagram node was never backfilled.src/__tests__/services/baseCreateDocument.test.ts— direct unit coverage of thehookAfterSavereplacement propagation.src/__tests__/candidate_profile/BaseService.test.ts— spot-checks a real CV section create flow through the unmockedcreateCrudService/BaseService.ts/services/index.tscode path (only the Mongoose model is faked) — confirms the response's_idis the real persisted id, notnull.agent-hub/: backfilled evidence (implementer + verifier) and sealed nodefix-create-response-null-id.Commits
Test plan
npm test— 140 passed, 140 totalnpm run build— clean🤖 Generated with Claude Code