test(candidate_me): add regression coverage for ObjectId candidateId filter - #168
Merged
Merged
Conversation
…filter Closes #153. The production fix was already live on staging as part of the fix-candidate-me-nosql-filter-collapse pass (issue #135, SEALED 2026-09-19) — handlerGetAboutMe already stringifies the ObjectId _id before filtering CV-section queries by candidateId — but no test ever exercised an ObjectId-typed _id specifically (every existing test used a plain string, which would pass even with the old bug), and the diagram node was never backfilled. - src/__tests__/candidate_me/index.test.ts: new describe block using a fake ObjectId-like _id (only a .toString() method, not a string) and asserting every CV-section query receives the stringified candidateId, never the raw object, never silently dropped. - agent-hub: backfill evidence (implementer + verifier) and seal node fix-candidate-me-candidateid-not-string. npm test: 141 passed, 141 total (independently re-run by the verifier subagent, matching exactly). npm run build: clean. Node: fix-candidate-me-candidateid-not-string (SEALED) Evidence: agent-hub/evidence/implementer/2026-09-28/fix-candidate-me-candidateid-not-string-plan.md, agent-hub/evidence/verifier/2026-09-28/fix-candidate-me-candidateid-not-string-seal.md Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #153. The production fix was already live on
stagingas part of thefix-candidate-me-nosql-filter-collapsepass (issue #135, SEALED 2026-09-19) —handlerGetAboutMealready stringifies the ObjectId_idbefore filtering CV-section queries bycandidateId— but no test ever exercised an ObjectId-typed_idspecifically (every existing test used a plain string, which would pass even with the old bug), and the diagram node was never backfilled.src/__tests__/candidate_me/index.test.ts— new describe block using a fake ObjectId-like_id(only a.toString()method, not a string) and asserting every CV-section query receives the stringifiedcandidateId, never the raw object, never silently dropped.agent-hub/: backfilled evidence (implementer + verifier) and sealed nodefix-candidate-me-candidateid-not-string.Commits
Test plan
npm test— 141 passed, 141 total (independently re-run by the verifier subagent)npm run build— clean🤖 Generated with Claude Code