test(services): add coverage for Puppeteer executablePath resolution - #169
Merged
Merged
Conversation
Closes #154. The production fix was already live on staging since add-docker-support (issue #24, SEALED 2026-09-06) — createCV already uses PUPPETEER_EXECUTABLE_PATH as an optional override, falling back to Puppeteer's own bundled Chromium resolution when unset, with no hardcoded path anywhere. Live-Docker-verified previously, but never unit-tested, and the diagram node was never backfilled. - src/__tests__/services/createPDF.test.ts: mocks puppeteer.launch entirely (no real browser spawned) and asserts createCV calls it with no executablePath key when PUPPETEER_EXECUTABLE_PATH is unset, and with that exact value when set. - agent-hub: backfill evidence (implementer + verifier) and seal node fix-chrome-executable-path. npm test: 142 passed, 142 total. npm run build: clean. Node: fix-chrome-executable-path (SEALED) Evidence: agent-hub/evidence/implementer/2026-09-28/fix-chrome-executable-path-plan.md, agent-hub/evidence/verifier/2026-09-28/fix-chrome-executable-path-seal.md Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #154. The production fix was already live on
stagingsinceadd-docker-support(issue #24, SEALED 2026-09-06) —createCValready usesPUPPETEER_EXECUTABLE_PATHas an optional override, falling back to Puppeteer's own bundled Chromium resolution when unset, with no hardcoded path anywhere. Live-Docker-verified previously, but never unit-tested, and the diagram node was never backfilled.src/__tests__/services/createPDF.test.ts— mockspuppeteer.launchentirely (no real browser spawned) and assertscreateCVcalls it with noexecutablePathkey whenPUPPETEER_EXECUTABLE_PATHis unset, and with that exact value when set.agent-hub/: backfilled evidence (implementer + verifier) and sealed nodefix-chrome-executable-path.Commits
Test plan
npm test— 142 passed, 142 totalnpm run build— clean🤖 Generated with Claude Code