Skip to content

test(auth): add regression coverage proving v2 register reaches the fixed handler - #171

Merged
datvt243 merged 2 commits into
stagingfrom
156-post-apiv2-authregister
Sep 27, 2026
Merged

datvt243 merged 2 commits into
stagingfrom
156-post-apiv2-authregister

Conversation

@datvt243

Copy link
Copy Markdown
Owner

Summary

Closes #156. The originally buggy file (src/api/v1/auth/services/register.ts, missing await on bcryptGenerateSalt) no longer exists — it was removed by consolidate-v1-v2-auth (issue #77, SEALED 2026-08-29), which merged v1/v2 auth into one shared implementation. v2/auth.route.ts now wires /register to the same authRegister controller v1 uses, whose handlerRegister already awaits bcryptGenerateSalt correctly (already indirectly proven by the existing auth.service.test.ts assertion). The diagram node was never backfilled after the consolidation.

  • src/__tests__/auth/v2AuthRoute.test.ts — asserts v2's /register route handler is the literal same authRegister function reference as v1 — proves v2 reaches the already-correct, already-tested handler, not a separate still-broken code path.
  • agent-hub/: backfilled evidence (implementer + verifier) and sealed node fix-v2-register-missing-await.

Commits

  • 5437632 test(auth): add regression coverage proving v2 register reaches the fixed handler
  • (+ a merge commit syncing origin/staging, needed since this branch was cut before the other 4 issues in this batch merged)

Test plan

  • npm test — 141 passed, 141 total on the original commit (independently re-run by the verifier subagent); 150 passed, 150 total after syncing staging
  • npm run build — clean

🤖 Generated with Claude Code

datvt243 and others added 2 commits September 28, 2026 01:33
…ixed handler

Closes #156. The originally buggy file (src/api/v1/auth/services/
register.ts, missing await on bcryptGenerateSalt) no longer exists —
it was removed by consolidate-v1-v2-auth (issue #77, SEALED
2026-08-29), which merged v1/v2 auth into one shared implementation.
v2/auth.route.ts now wires /register to the same authRegister
controller v1 uses, whose handlerRegister already awaits
bcryptGenerateSalt correctly (already indirectly proven by the
existing auth.service.test.ts assertion). The diagram node was never
backfilled after the consolidation.

- src/__tests__/auth/v2AuthRoute.test.ts: asserts v2's /register route
  handler is the literal same authRegister function reference as v1 —
  proves v2 reaches the already-correct, already-tested handler, not a
  separate still-broken code path.
- agent-hub: backfill evidence (implementer + verifier) and seal node
  fix-v2-register-missing-await.

npm test: 141 passed, 141 total (independently re-run by the verifier
subagent). npm run build: clean.

Node: fix-v2-register-missing-await (SEALED)
Evidence: agent-hub/evidence/implementer/2026-09-28/fix-v2-register-missing-await-plan.md,
agent-hub/evidence/verifier/2026-09-28/fix-v2-register-missing-await-seal.md

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datvt243
datvt243 merged commit 4b84729 into staging Sep 27, 2026
3 checks passed
@datvt243
datvt243 deleted the 156-post-apiv2-authregister branch September 27, 2026 18:34
@datvt243 datvt243 mentioned this pull request Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant