test(auth): add regression coverage proving v2 register reaches the fixed handler - #171
Merged
Merged
Conversation
…ixed handler Closes #156. The originally buggy file (src/api/v1/auth/services/ register.ts, missing await on bcryptGenerateSalt) no longer exists — it was removed by consolidate-v1-v2-auth (issue #77, SEALED 2026-08-29), which merged v1/v2 auth into one shared implementation. v2/auth.route.ts now wires /register to the same authRegister controller v1 uses, whose handlerRegister already awaits bcryptGenerateSalt correctly (already indirectly proven by the existing auth.service.test.ts assertion). The diagram node was never backfilled after the consolidation. - src/__tests__/auth/v2AuthRoute.test.ts: asserts v2's /register route handler is the literal same authRegister function reference as v1 — proves v2 reaches the already-correct, already-tested handler, not a separate still-broken code path. - agent-hub: backfill evidence (implementer + verifier) and seal node fix-v2-register-missing-await. npm test: 141 passed, 141 total (independently re-run by the verifier subagent). npm run build: clean. Node: fix-v2-register-missing-await (SEALED) Evidence: agent-hub/evidence/implementer/2026-09-28/fix-v2-register-missing-await-plan.md, agent-hub/evidence/verifier/2026-09-28/fix-v2-register-missing-await-seal.md Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #156. The originally buggy file (
src/api/v1/auth/services/register.ts, missingawaitonbcryptGenerateSalt) no longer exists — it was removed byconsolidate-v1-v2-auth(issue #77, SEALED 2026-08-29), which merged v1/v2 auth into one shared implementation.v2/auth.route.tsnow wires/registerto the sameauthRegistercontroller v1 uses, whosehandlerRegisteralready awaitsbcryptGenerateSaltcorrectly (already indirectly proven by the existingauth.service.test.tsassertion). The diagram node was never backfilled after the consolidation.src/__tests__/auth/v2AuthRoute.test.ts— asserts v2's/registerroute handler is the literal sameauthRegisterfunction reference as v1 — proves v2 reaches the already-correct, already-tested handler, not a separate still-broken code path.agent-hub/: backfilled evidence (implementer + verifier) and sealed nodefix-v2-register-missing-await.Commits
origin/staging, needed since this branch was cut before the other 4 issues in this batch merged)Test plan
npm test— 141 passed, 141 total on the original commit (independently re-run by the verifier subagent); 150 passed, 150 total after syncing stagingnpm run build— clean🤖 Generated with Claude Code