test(auth): add regression coverage for i18n across the auth flow (#159) - #176
Merged
Merged
Conversation
i18n infra (utils/i18n.ts's t()/tErrorType(), locales/{vi,en}.ts,
language.middleware.ts) and the full auth-flow migration (register/
login/logout/refresh/forgot-password/reset-password/verify-email, all
21 message sites) were already implemented and live. Adds the missing
regression tests:
- src/__tests__/utils/i18n.test.ts (new): unit tests for t()/tErrorType()
— per-language resolution, default-lang fallback, key-as-fallback,
flat vs dot-path lookup.
- src/__tests__/middlewares/language.test.ts (new): unit tests for
languageMiddleware's Accept-Language resolution (plain/regional/
multi-tag/case-insensitive/unsupported) and req.t() wiring.
- src/__tests__/auth/auth.controller.test.ts (extended): 5 new
English-language cases proving req.lang drives real (unmocked) t()
output at the controller boundary, alongside the pre-existing
vi-default cases.
0 production code changed.
npm test: 31 suites / 181 tests passed.
npm run build: clean.
Sealed node: feat-i18n-api-messages-auth
Evidence: agent-hub/evidence/implementer/2026-10-01/feat-i18n-api-messages-auth-plan.md,
agent-hub/evidence/verifier/2026-10-01/feat-i18n-api-messages-auth-seal.md
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29571135 | Triggered | Generic Password | 9d4b69a | src/tests/auth/auth.controller.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits going into staging
Summary
The i18n infrastructure (
utils/i18n.ts,locales/{vi,en}.ts,language.middleware.ts) and the full auth-flow migration (register/login/logout/refresh/forgot-password/reset-password/verify-email) were already implemented and live — all 21 message sites already resolve throught(). This adds the missing regression tests: unit tests fort()/tErrorType(), unit tests forlanguageMiddleware's Accept-Language resolution, and 5 new English-language cases at the auth-controller boundary provingreq.langdrives real localized output. 0 production code changed.Closes #159.
🤖 Generated with Claude Code