Repository navigation
[system] parse user_changed_user_id updates without from - #236
Open
jamalkamaladdin wants to merge 1 commit into
Open
jamalkamaladdin wants to merge 1 commit into
jamalkamaladdin wants to merge 1 commit into
Conversation
…se previous BSUIDs. fixes david-lev#235
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #236 +/- ##
=======================================
Coverage 79.96% 79.96%
=======================================
Files 55 55
Lines 9487 9489 +2
=======================================
+ Hits 7586 7588 +2
Misses 1901 1901 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #235.
PhoneNumberChange.from_updatereadsfromwith.get().old_wa_idandfrom_user.wa_idareNonefor auser_changed_user_idupdate withoutfrom.New fields
old_user_idandold_parent_idholdprevious_user_idandprevious_parent_user_id.Docstrings in
pywa/types/system.pyandpywa_async/types/system.pylist both new fields.Type of change
Checklist
How has this been tested?
tests/data/updates/system.json: newuser_id_changepayload withoutfrom, shaped after Meta'suser_changed_user_idexample.tests/test_updates.py: 6 checks foruser_id_changeon sync and async clients.Breaking changes
old_wa_idacceptsNone.Related issues / PRs
#235
Reviewer notes
None.