Skip to content

Lab: run-records base (lab-only integration branch) - #149

Draft
dayfine wants to merge 10 commits into
lab/mainfrom
lab/run-records-base
Draft

dayfine wants to merge 10 commits into
lab/mainfrom
lab/run-records-base

Conversation

@dayfine

@dayfine dayfine commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Lab-only integration branch, never for upstream: lab/tooling (#107) with main and #132 merged in, so that #116 can be reviewed as the Lab half only.

  • Merges only, no code of its own. The four files where main and the lab channel disagree are taken from lab/main.
  • Based on lab/main here so the pre-push code-health gate measures it against lab/main.

Testing

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 10 commits November 1, 2026 00:21
Game commands that watch the screen with run_until (frlg_route's walker)
crashed the app on a null inference pivot: a program's environment starts
those threads, the lab console did not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The framework half of fork PR #116 (5ffec9d), unchanged: RunRecord.h
with RunRecordStore and SessionRunRecorder, ProgramSession recording
every accepted run with exactly one result, ProgramEnvironment::
run_recorder(), the console sessions' loggers chained through the run
logger, and the RunRecord unit tests. Nothing here depends on the lab
channel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…efault

- Each record names the app's version, the git commit it was built from
  (PROGRAM_COMMIT, written into BuildCommit.cpp by cmake/BuildCommit.cmake
  on every build and rewritten only when the commit changes) and the
  program's settings as the settings file stores them.
- The log is numbered line by line, so a reader can copy it out as it
  grows: the store keeps a 256 KiB tail and records at most 8 MiB per run,
  counting the lines past that.
- The app's store records nothing until it is enabled; whoever reads the
  records enables it. Tests build their own, enabled stores.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The base for fork PR #116: lab/tooling (#107) with main, so the
framework half of the run records (common/run-records, on main) can be
merged in. The four conflicting files are taken from lab/main, which
already joins main and the lab channel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The framework half of the run records, for the Lab half on fork PR #116.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
- The progress hook is a free function, record_run_event(env, event), in
  place of the single-method RunRecorder interface; ProgramSession and
  ProgramEnvironment gain no public method (the lab reads run IDs from
  the store).
- The app's store is app_run_records(), switched on by
  enable_app_run_records(); a store takes an optional flag in place of a
  defaulted bool and set_enabled().
- start_program() and run_program() hand their accepted-start,
  preparation, download and end steps to private helpers, so neither
  grows past its old size or nesting.
- The store's events and log tests are two tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The code-health fixes of #132.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Per the decision on the design: main takes no CMake change. A record
names the app's version and the path of its executable (a lab build's
folder names the build); the git commit (cmake/BuildCommit.cmake) moves
to the lab half, #116.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
#132 names the executable; the git commit moves to #116.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant