Repository navigation
Conversation
Game commands that watch the screen with run_until (frlg_route's walker) crashed the app on a null inference pivot: a program's environment starts those threads, the lab console did not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The framework half of fork PR #116 (5ffec9d), unchanged: RunRecord.h with RunRecordStore and SessionRunRecorder, ProgramSession recording every accepted run with exactly one result, ProgramEnvironment:: run_recorder(), the console sessions' loggers chained through the run logger, and the RunRecord unit tests. Nothing here depends on the lab channel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…efault - Each record names the app's version, the git commit it was built from (PROGRAM_COMMIT, written into BuildCommit.cpp by cmake/BuildCommit.cmake on every build and rewritten only when the commit changes) and the program's settings as the settings file stores them. - The log is numbered line by line, so a reader can copy it out as it grows: the store keeps a 256 KiB tail and records at most 8 MiB per run, counting the lines past that. - The app's store records nothing until it is enabled; whoever reads the records enables it. Tests build their own, enabled stores. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The base for fork PR #116: lab/tooling (#107) with main, so the framework half of the run records (common/run-records, on main) can be merged in. The four conflicting files are taken from lab/main, which already joins main and the lab channel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The framework half of the run records, for the Lab half on fork PR #116. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
- The progress hook is a free function, record_run_event(env, event), in place of the single-method RunRecorder interface; ProgramSession and ProgramEnvironment gain no public method (the lab reads run IDs from the store). - The app's store is app_run_records(), switched on by enable_app_run_records(); a store takes an optional flag in place of a defaulted bool and set_enabled(). - start_program() and run_program() hand their accepted-start, preparation, download and end steps to private helpers, so neither grows past its old size or nesting. - The store's events and log tests are two tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The code-health fixes of #132. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Per the decision on the design: main takes no CMake change. A record names the app's version and the path of its executable (a lab build's folder names the build); the git commit (cmake/BuildCommit.cmake) moves to the lab half, #116. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
#132 names the executable; the git commit moves to #116. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lab-only integration branch, never for upstream: lab/tooling (#107) with main and #132 merged in, so that #116 can be reviewed as the Lab half only.
Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E