Repository navigation
Conversation
Owner
Author
Owner
Author
|
Reopened: closing superseded PRs is the user's call (autostory/PR_PLAN.md). Proposed for closing; see the comment above. |
Owner
Author
|
Closed as superseded (user OK, 2026-11-02). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
main; no parent PRs. This diff contains only the Max Lair fix and regression tests.Boss Finder could remember a rental (
mimikyu-disguised) as the legendary boss, retain it after correctly reading Kyurem, then crash on the three-catch results screen after a loss. Validate opponents against the battle stage, repair invalid boss identity, and apply boss catch/stop rules only when the boss was caught. Keep the encountered boss for Save Path handling.Validation: ten new native regression cases pass; full builds/tests pass on Linux, Mac, and Windows Clang. Code health passes. Not yet deployed or tested on a Switch.
How to review
Read the two new
GlobalStatehelpers, then the battle/results call sites and tests. The existing boss-inference branch moved out ofread_battle_menuwith changed validation; the surrounding controller sequence stays in place.