Skip to content

Fix Max Lair Boss Finder after failed adventures - #170

Closed
dayfine wants to merge 1 commit into
mainfrom
swsh/maxlair-boss-identification
Closed

dayfine wants to merge 1 commit into
mainfrom
swsh/maxlair-boss-identification

Conversation

@dayfine

@dayfine dayfine commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Base: main; no parent PRs. This diff contains only the Max Lair fix and regression tests.

Boss Finder could remember a rental (mimikyu-disguised) as the legendary boss, retain it after correctly reading Kyurem, then crash on the three-catch results screen after a loss. Validate opponents against the battle stage, repair invalid boss identity, and apply boss catch/stop rules only when the boss was caught. Keep the encountered boss for Save Path handling.

Validation: ten new native regression cases pass; full builds/tests pass on Linux, Mac, and Windows Clang. Code health passes. Not yet deployed or tested on a Switch.

How to review

Read the two new GlobalState helpers, then the battle/results call sites and tests. The existing boss-inference branch moved out of read_battle_menu with changed validation; the surrounding controller sequence stays in place.

git diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change main...swsh/maxlair-boss-identification

@dayfine

dayfine commented Nov 2, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #171 (tests, no behavior change) and #172 (the fix), which split this change; #172's files match this branch exactly.

@dayfine dayfine closed this Nov 2, 2026
@dayfine dayfine reopened this Nov 2, 2026
@dayfine

dayfine commented Nov 2, 2026

Copy link
Copy Markdown
Owner Author

Reopened: closing superseded PRs is the user's call (autostory/PR_PLAN.md). Proposed for closing; see the comment above.

@dayfine

dayfine commented Nov 2, 2026

Copy link
Copy Markdown
Owner Author

Closed as superseded (user OK, 2026-11-02).

@dayfine dayfine closed this Nov 2, 2026
@dayfine
dayfine deleted the swsh/maxlair-boss-identification branch November 13, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant