Skip to content

PokemonSV: test the Blueberry quest detector on reference frames - #180

Closed
dayfine wants to merge 3 commits into
mainfrom
sv/bbq-quest-detector-tests
Closed

dayfine wants to merge 3 commits into
mainfrom
sv/bbq-quest-detector-tests

Conversation

@dayfine

@dayfine dayfine commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

BlueberryQuestDetector, the OCR the BBQ Farmer uses to read its quests, had no tests. The two Traditional Chinese quest panel frames already in CommandLineTests under PokemonSV/BlueberryPoints/ (added for the BP reader in PokemonAutomation#1628) also show three quests each, so this adds 16 PokemonSV::BlueberryQuestDetector image tests next to the detector in PokemonSV_BlueberryQuestDetector.cpp, registered from PokemonSV_Tests.cpp like the other SV detector tests: every slot of both frames at 1080p and 720p, with the empty fourth slot expected to read as nothing. One frame shows 捕捉1隻… where the dictionary has 捕捉一隻…, so the tests also cover the fuzzy match accepting that. No CommandLineTests change is needed; like Chinese OCR in the app, the tests need the PaddleOCR detection model. All 16 pass locally, run through a small harness linked against a current SerialPrograms library build.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

pa-devbot and others added 3 commits November 2, 2026 09:29
…ation#1829)

Two residuals of the cross-backend send() inconsistency:

- The WinSocket client returned on the first partial ::send() call
  (mid-block), while the POSIX and Qt backends keep sending until
  everything is written, the deadline elapses, or close() cancels the
  send. It now advances and loops like them; the loop condition
  re-checks the deadline and the state each iteration, so the
  cancellation and deadline behavior is unchanged.
- The WinSocket server passed the raw payload length to ::send(),
  which takes an int: a payload larger than 2 GiB wrapped the length
  negative. It now chunks the send at 1 GiB, the same cap the
  WinSocket client already uses.

Co-authored-by: PA Dev Bot <344001113+pa-devbot@users.noreply.github.com>
The two Traditional Chinese quest panel frames under
PokemonSV/BlueberryPoints also show three quests each. Read every slot of
both at 1080p and 720p; the empty fourth slot reads as nothing, and
"捕捉1隻..." on screen must fuzzy-match the dictionary's "捕捉一隻...".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Like the other SV detectors, the test class and add_tests_ function live
next to the detector; PokemonSV_Tests.cpp only registers them. One helper
adds a frame's slots so each frame is one line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 4 PR #275.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the sv/bbq-quest-detector-tests branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants