Repository navigation
Conversation
…ation#1829) Two residuals of the cross-backend send() inconsistency: - The WinSocket client returned on the first partial ::send() call (mid-block), while the POSIX and Qt backends keep sending until everything is written, the deadline elapses, or close() cancels the send. It now advances and loops like them; the loop condition re-checks the deadline and the state each iteration, so the cancellation and deadline behavior is unchanged. - The WinSocket server passed the raw payload length to ::send(), which takes an int: a payload larger than 2 GiB wrapped the length negative. It now chunks the send at 1 GiB, the same cap the WinSocket client already uses. Co-authored-by: PA Dev Bot <344001113+pa-devbot@users.noreply.github.com>
The two Traditional Chinese quest panel frames under PokemonSV/BlueberryPoints also show three quests each. Read every slot of both at 1080p and 720p; the empty fourth slot reads as nothing, and "捕捉1隻..." on screen must fuzzy-match the dictionary's "捕捉一隻...". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Like the other SV detectors, the test class and add_tests_ function live next to the detector; PokemonSV_Tests.cpp only registers them. One helper adds a frame's slots so each frame is one line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
added a commit
that referenced
this pull request
Nov 2, 2026
Owner
Author
|
Superseded by consolidated Tree 4 PR #275. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlueberryQuestDetector, the OCR the BBQ Farmer uses to read its quests, had no tests. The two Traditional Chinese quest panel frames already in CommandLineTests underPokemonSV/BlueberryPoints/(added for the BP reader in PokemonAutomation#1628) also show three quests each, so this adds 16PokemonSV::BlueberryQuestDetectorimage tests next to the detector inPokemonSV_BlueberryQuestDetector.cpp, registered fromPokemonSV_Tests.cpplike the other SV detector tests: every slot of both frames at 1080p and 720p, with the empty fourth slot expected to read as nothing. One frame shows捕捉1隻…where the dictionary has捕捉一隻…, so the tests also cover the fuzzy match accepting that. No CommandLineTests change is needed; like Chinese OCR in the app, the tests need the PaddleOCR detection model. All 16 pass locally, run through a small harness linked against a current SerialPrograms library build.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E