Repository navigation
Conversation
dayfine
added a commit
that referenced
this pull request
Oct 23, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
PokemonSV_Tests.cpp registers every SV test, and each BBQ change adds its controller tests there, so parallel BBQ changes all conflict in it. Move the Tera encounter tests unchanged into Programs/Farming/PokemonSV_BBQTests.cpp, registered through one add_tests_BBQ() call, following the add_tests_<Module>() pattern the detectors use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
quest_catch() watches for the battle menu twice: an inner wait_until() and the outer EncounterWatcher. When the inner one saw the menu first, run_until() returned -1, the battle was treated as "no battle", and return_to_plaza() fled from the target. Logs show 7 of 22 catch-quest battles lost this way; no battle ever started after the 25 s timeout. - Count the inner watcher's battle menu as a battle. - Catch Any: catch a battle that starts on the way back to Central Plaza until this attempt has battled (return_to_plaza_unless_battle(), opt-in; return_to_plaza() is unchanged). Typed catch quests still flee. - Skip the Pokecenter heal and re-fly after an attempt with no battle: the player is still on the Central Plaza fly point (~28 s per attempt). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/catch-grace-and-heal
branch
from
October 28, 2026 08:08
99377cf to
70cf43c
Compare
dayfine
force-pushed
the
bbq/tests-file
branch
2 times, most recently
from
October 28, 2026 20:37
bf82b48 to
daa1de3
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 4 PR #275. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
quest_catch()fled from 7 of 22 logged catch battles: when its inner battle-menu wait saw the battle before the outerEncounterWatcher,run_until()returned -1 andreturn_to_plaza()ran from the target. It now counts that menu as a battle; Catch Any also catches a battle on the way back until the attempt has battled, through the newreturn_to_plaza_unless_battle()(return_to_plaza()is unchanged); and an attempt with no battle skips the Pokémon Center heal and re-fly, about 28 s each (behavior change). SixPokemonSV::BBQCatchOnReturntests inPokemonSV_BBQTests.cppcover when a battle on the way back is caught; the native BBQ runner passes 16 of 16 with the full app built on macOS arm64. Not yet run on a Switch: a live run should see the race case caught and the nextcentral_to_*flight land correctly after a skipped heal.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E