Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Conflict in Main.cpp: main no longer defines use_qt_ui() there, so the file-local namespace opens right after Q_DECLARE_METATYPE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
main. No feature or lab parents; this diff is a mechanical prerequisite for lab PR #233.Extract the existing service shutdown and worker-pool shutdown blocks from
Main.cppinto file-local helpers. Calls, their order, conditional compilation, and the Windows Qt quick-exit workaround stay unchanged. File-local helpers now share one anonymous namespace insidePokemonAutomation, with nousing namespacedirective;main()and Qt metatype registration remain global. There are no argument-validation, profile-policy, test-mode or device-startup changes here.Validation: code health passes against
origin/main; whitespace checks pass. Full application builds and native suites are dispatched on macOS, Windows Clang and Ubuntu. No console or app deployment is involved.How to review
Review this PR before #233. The helper bodies are moved from the end of
main()without changing their statements. Compare using:This branch is based on fork main and contains no lab tooling, so it can be prepared for an upstream handoff independently. This is a draft on the fork, not an upstream submission.
Code-health dependency: #235 fixes baseline matching for namespace moves and namespace comments after metatype macros. This C++ revision passes the updated linter; canonical CI requires that tooling PR to merge into
agentsfirst.