Skip to content

Fix IDE source grouping for external build directories - #242

Draft
dayfine wants to merge 10 commits into
mainfrom
build/external-generated-source-groups
Draft

dayfine wants to merge 10 commits into
mainfrom
build/external-generated-source-groups

Conversation

@dayfine

@dayfine dayfine commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Based on fork main; no lab or gameplay parents. The diff contains only this build fix and configure-only regression coverage.

Configuring SerialPrograms into a build directory outside the source checkout fails when source_group(TREE ...) receives Qt's generated qrc_darkstyle.cpp: the source-tree root cannot be a prefix of that binary-directory path. The two dev slots exposed this existing assumption.

Partition IDE grouping by CMake's GENERATED source property. Authored files retain their existing tree; generated files use a separate group independent of output location. Target source lists, compilation and runtime behavior are unchanged.

How to review: the CMakeLists change calls the small shared helper in cmake/SourceGroups.cmake; the fixtures exercise the same generated-file property used by qt_add_resources. Two cases failed with the original grouping; all five pass after the fix, including mixed/all-generated lists, paths containing spaces, authored/empty lists and rejection of an unrelated external authored file. CI runs those configure-only cases on Linux, Windows and macOS without Qt, compilation or devices.

Validation: reproduced the reported prefix error; five local CTest cases pass and whitespace checks pass. The actual slot-B application configure now succeeds in /Users/difan/Projects/dev-builds/slot-B, using the existing Qt/cache and PA_LAB_PROFILE=lab-B. The fix is merged into both local lab/dev-* branches. Five configure cases also pass on Linux and Windows CI; macOS CI remains queued. No full app build, GUI or console operation was run for this fix.

dayfine and others added 10 commits November 6, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant