Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on fork main; no lab or gameplay parents. The diff contains only this build fix and configure-only regression coverage.
Configuring SerialPrograms into a build directory outside the source checkout fails when
source_group(TREE ...)receives Qt's generatedqrc_darkstyle.cpp: the source-tree root cannot be a prefix of that binary-directory path. The two dev slots exposed this existing assumption.Partition IDE grouping by CMake's GENERATED source property. Authored files retain their existing tree; generated files use a separate group independent of output location. Target source lists, compilation and runtime behavior are unchanged.
How to review: the CMakeLists change calls the small shared helper in
cmake/SourceGroups.cmake; the fixtures exercise the same generated-file property used by qt_add_resources. Two cases failed with the original grouping; all five pass after the fix, including mixed/all-generated lists, paths containing spaces, authored/empty lists and rejection of an unrelated external authored file. CI runs those configure-only cases on Linux, Windows and macOS without Qt, compilation or devices.Validation: reproduced the reported prefix error; five local CTest cases pass and whitespace checks pass. The actual slot-B application configure now succeeds in
/Users/difan/Projects/dev-builds/slot-B, using the existing Qt/cache andPA_LAB_PROFILE=lab-B. The fix is merged into both locallab/dev-*branches. Five configure cases also pass on Linux and Windows CI; macOS CI remains queued. No full app build, GUI or console operation was run for this fix.