Repository navigation
Conversation
…into tooling/cmake-incremental-format
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ental-format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #245 (
tooling/incremental-cpp-format); the diff contains the CMake targets, tests and usage notes.Add
cmake --build <build-dir> --target formatandformat-check, backed by the edited-line formatter.formatapplies eligible spacing;format-checkpreviews and fails if eligible changes remain. Both operate on the configured source checkout and use HEAD by default, withPA_FORMAT_BASEfor a branch parent.The targets have no app-build dependency. Python discovery happens at target time, so normal app configuration gains no mandatory formatter/Python dependency. The command uses Uncrustify 0.83.0 plus Clang's token check; clang-format is not required. A Python path can be supplied through
PA_FORMAT_PYTHON.Validation: all 38 local tests pass, including real CMake configure/build invocations with paths containing spaces, missing-Python diagnostics, committed-base selection and proof that the formatting targets do not run an unrelated ALL/app target. Actual SerialPrograms core-only configure and both formatting targets also pass without building the application. The parent workflow now covers these CMake paths and discovers all tests in CI.
Read
SerialPrograms/cmake/Formatting.cmake, its target-time adapter, thendevtools/format/test_cmake.py. Usage and source-checkout scope are indevtools/format/CMAKE.md.Formatter/CMake CI passes all 38 tests. Code Health and tabs pass. Actual core-only configure and both real formatting targets also pass; neither target builds the app.