Repository navigation
Lab: merge lab/tooling into lab/main (lab commands start inference threads) - #256
Merged
Merged
Conversation
Game commands that watch the screen with run_until (frlg_route's walker) crashed the app on a null inference pivot: a program's environment starts those threads, the lab console did not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…es their default button A failed program leaves a modal Error box that nothing at the keyboard closes on a lab console. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
After a program switch the app reconnects the controller, which can stall. A start in that window ran the program, which then failed with "Incompatible Controller ... Actual: (none)". The state file now has controller=ready|none from the panel's ControllerSession, and start waits up to SECONDS (default 30) for it, refusing with "controller not connected". labctl.sh passes a wait shorter than its own request timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…s, controller status Brings 5c26218, which starts the console's inference threads for each lab command. Without it, close_game through the lab channel with no program running crashed on a null inference pivot (lab-B, 2026-11-08 08:53 and 08:57). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base: lab/main. Parent: #107 (lab/tooling); the diff is lab/tooling's four commits not yet on lab/main.
A lab channel
close_gamewith no program running crashed lab-B twice on 2026-11-08 (08:53, 08:57):go_homewaits on video detection, and the lab console's ConsoleHandle had no inference pivot, soadd_callbackhit a null pointer. lab/tooling already fixed this in 5c26218 (LabConsole starts the console's inference threads for every command, so every runner line and registered game command that uses wait_until/run_until gets them), but lab/main never merged it, so lab builds still lacked it. The merge is clean and also brings the popups and start/controller-status commits. Tested with a local macOS build of this merge plus #257: the LabChannel, LabDevices and CommandFileRunner suites pass in --command-line-test-mode (other failures are missing CommandLineTests images); no console run.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss