Skip to content

Lab: merge lab/tooling into lab/main (lab commands start inference threads) - #256

Merged
dayfine merged 8 commits into
lab/mainfrom
lab/main-merge-tooling
Nov 8, 2026
Merged

dayfine merged 8 commits into
lab/mainfrom
lab/main-merge-tooling

Conversation

@dayfine

@dayfine dayfine commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Base: lab/main. Parent: #107 (lab/tooling); the diff is lab/tooling's four commits not yet on lab/main.

A lab channel close_game with no program running crashed lab-B twice on 2026-11-08 (08:53, 08:57): go_home waits on video detection, and the lab console's ConsoleHandle had no inference pivot, so add_callback hit a null pointer. lab/tooling already fixed this in 5c26218 (LabConsole starts the console's inference threads for every command, so every runner line and registered game command that uses wait_until/run_until gets them), but lab/main never merged it, so lab builds still lacked it. The merge is clean and also brings the popups and start/controller-status commits. Tested with a local macOS build of this merge plus #257: the LabChannel, LabDevices and CommandFileRunner suites pass in --command-line-test-mode (other failures are missing CommandLineTests images); no console run.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 8 commits November 1, 2026 00:21
Game commands that watch the screen with run_until (frlg_route's walker)
crashed the app on a null inference pivot: a program's environment starts
those threads, the lab console did not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…es their default button

A failed program leaves a modal Error box that nothing at the keyboard
closes on a lab console.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
After a program switch the app reconnects the controller, which can stall.
A start in that window ran the program, which then failed with
"Incompatible Controller ... Actual: (none)". The state file now has
controller=ready|none from the panel's ControllerSession, and start waits up
to SECONDS (default 30) for it, refusing with "controller not connected".
labctl.sh passes a wait shorter than its own request timeout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…s, controller status

Brings 5c26218, which starts the console's inference threads for each lab
command. Without it, close_game through the lab channel with no program
running crashed on a null inference pivot (lab-B, 2026-11-08 08:53 and 08:57).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine marked this pull request as ready for review November 8, 2026 20:58
@dayfine
dayfine merged commit 68ecbf8 into lab/main Nov 8, 2026
15 of 19 checks passed
@dayfine
dayfine deleted the lab/main-merge-tooling branch November 8, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant