Repository navigation
Conversation
Make TM and Travel 500 m start at the Central Plaza fly point and fly back to it. After one completes, the panel read that checked it is reused: - for the next quest of the round when that is also a no-trip quest, and - to plan the next round when it was the last quest, skipping the round actions (date fix) unless a save is due or the quest goal is reached. do_quest() now hands back the panel read that checked the last attempt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/panel-read-reuse
branch
from
October 23, 2026 04:25
57088de to
f4d4c47
Compare
dayfine
force-pushed
the
bbq/batch-quests
branch
from
October 23, 2026 04:25
ceac9f9 to
778fe05
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
Problem
M15 step 1 (roadmap item 16): quests that never leave Central Plaza still pay per-quest overhead between them. Make TM and Travel 500 m start at the Central Plaza fly point and fly back to it, yet:
process_and_do_quest()read it to check the last attempt;Change (part (b): no-trip quests back to back)
bbq_quest_is_no_trip():make_tm,travel_500. Every other route flies out: sandwiches go to Polar Plaza, hatch and wash to Savanna Plaza, photo/catch/battle routes to their areas.process_and_do_quest()takes an optionalpanel_afterout-parameter: the panel read that checked the last attempt.BBQGameActions::do_quest()passes it back.run_bbq_rounds(), after a no-trip quest completes, its read is reusedend_round()).forget_quests_gone_from_panel()handling as a fresh one.Savings per chained step: one panel read (~5 s) within a round; one read plus the date fix (~15-20 s) across rounds. This is smaller than the ~1.5-2 min roadmap estimate: the loop already runs a whole board per round, and each trip route's own fly out /
return_to_plazais not something (b) can remove.Part (a), same-target pairs: not implemented (design note)
Photo-X and catch-X routes reach the same plaza for some types, but not the same spot: e.g. photo-ghost and catch-ghost both start with
central_to_canyon_plaza()and the same glide, but with different glide timings (2000 vs 2400 ms) and catch-ghost adds a further move. Other pairs start from different fly points: photo-water flies to the Polar classroom, catch-water to Polar rest area; photo-electric flies to the Canyon rest area, catch-electric walks to a Geodude-A from Central Plaza. photo-fire and catch-fire both fly to Savanna Plaza, again with different paths after landing. A combined route needs:quest_photo()to end at the target withoutreturn_to_plaza(), thenquest_catch()to start from the current position instead of a Central Plaza fly;That is new navigation code that needs live runs per pair, so it is left for a later step.
Tests
5 new
BBQFarmerRoundsscenarios (designated initializers,SimulatedBBQGameActions): two no-trip quests chained with no round actions between; no-trip then trip quest on one board (trip reads as usual); failed no-trip quest ends the round as usual; no chaining past a save; no chaining past the quest goal. 4 existing scenarios with Make TM / Travel 500 m back to back or at a round's end now expect the dropped read / round actions. Native runner: 58 passed, 0 failed (BBQFarmerRounds 27, was 22).Risks for a live run
ZLon the map plusfly_to_overworld_from_map(); this assumes it lands at the Central Plaza fly point like Make TM. If it lands elsewhere, the next quest's route starts from the wrong spot (the same assumption the old code made for the next quest in a round).How to review
No code moved. Read order:
PokemonSV_BBQSoloFarmer.h(interface),PokemonSV_BlueberryQuests.cpp(panel_after),run_bbq_rounds(), then the tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E