Skip to content

BBQ Farmer: chain no-trip quests without round actions between (M15 step 1b) - #26

Closed
dayfine wants to merge 7 commits into
bbq/panel-read-reusefrom
bbq/batch-quests
Closed

dayfine wants to merge 7 commits into
bbq/panel-read-reusefrom
bbq/batch-quests

Conversation

@dayfine

@dayfine dayfine commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Depends on: fork #22 (bbq/panel-read-reuse, C9), stacked on fork #13 (bbq/replan-after-reroll) and fork #12 (bbq/reuse-quest-board). Base branch: bbq/panel-read-reuse, so the diff shows only this change. None of these is upstream yet; the upstream base is PokemonAutomation/Arduino-Source main.

Part of PokemonAutomation/ComputerControl#263.

Problem

M15 step 1 (roadmap item 16): quests that never leave Central Plaza still pay per-quest overhead between them. Make TM and Travel 500 m start at the Central Plaza fly point and fly back to it, yet:

  • the round loop reads the panel before the next quest, right after process_and_do_quest() read it to check the last attempt;
  • when one ends a round, the round actions (HOME date fix) run and the panel is read again for scheduling, though nothing changed.

Change (part (b): no-trip quests back to back)

  • bbq_quest_is_no_trip(): make_tm, travel_500. Every other route flies out: sandwiches go to Polar Plaza, hatch and wash to Savanna Plaza, photo/catch/battle routes to their areas.
  • process_and_do_quest() takes an optional panel_after out-parameter: the panel read that checked the last attempt. BBQGameActions::do_quest() passes it back.
  • In run_bbq_rounds(), after a no-trip quest completes, its read is reused
    • for the next dispatch, if the next quest is also no-trip (a trip quest still reads first, as before);
    • to plan the next round, if it was the round's last quest: the round actions are skipped, unless a save is due or the quest goal is reached (those still run end_round()).
  • A failed no-trip quest keeps the normal flow (skip / reroll / stop, then round actions).
  • Completion is still verified by a panel read each time; only redundant reads are dropped. The reused read gets the same forget_quests_gone_from_panel() handling as a fresh one.

Savings per chained step: one panel read (~5 s) within a round; one read plus the date fix (~15-20 s) across rounds. This is smaller than the ~1.5-2 min roadmap estimate: the loop already runs a whole board per round, and each trip route's own fly out / return_to_plaza is not something (b) can remove.

Part (a), same-target pairs: not implemented (design note)

Photo-X and catch-X routes reach the same plaza for some types, but not the same spot: e.g. photo-ghost and catch-ghost both start with central_to_canyon_plaza() and the same glide, but with different glide timings (2000 vs 2400 ms) and catch-ghost adds a further move. Other pairs start from different fly points: photo-water flies to the Polar classroom, catch-water to Polar rest area; photo-electric flies to the Canyon rest area, catch-electric walks to a Geodude-A from Central Plaza. photo-fire and catch-fire both fly to Savanna Plaza, again with different paths after landing. A combined route needs:

  1. a per-type "shared target point" table, with hardware-validated paths for each pair;
  2. quest_photo() to end at the target without return_to_plaza(), then quest_catch() to start from the current position instead of a Central Plaza fly;
  3. a planner rule that orders photo-X before catch-X and passes the pair to one dispatch.
    That is new navigation code that needs live runs per pair, so it is left for a later step.

Tests

5 new BBQFarmerRounds scenarios (designated initializers, SimulatedBBQGameActions): two no-trip quests chained with no round actions between; no-trip then trip quest on one board (trip reads as usual); failed no-trip quest ends the round as usual; no chaining past a save; no chaining past the quest goal. 4 existing scenarios with Make TM / Travel 500 m back to back or at a round's end now expect the dropped read / round actions. Native runner: 58 passed, 0 failed (BBQFarmerRounds 27, was 22).

Risks for a live run

  • Skipping the date fix after a make-tm/travel-500 round: rounds with trip quests still run it, but a long run of no-trip rounds would postpone it.
  • Travel 500 m ends with ZL on the map plus fly_to_overworld_from_map(); this assumes it lands at the Central Plaza fly point like Make TM. If it lands elsewhere, the next quest's route starts from the wrong spot (the same assumption the old code made for the next quest in a round).
  • Stats/status notification after a chained round are not sent (only per-quest stats update).

How to review

No code moved. Read order: PokemonSV_BBQSoloFarmer.h (interface), PokemonSV_BlueberryQuests.cpp (panel_after), run_bbq_rounds(), then the tests.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Make TM and Travel 500 m start at the Central Plaza fly point and fly back
to it. After one completes, the panel read that checked it is reused:
- for the next quest of the round when that is also a no-trip quest, and
- to plan the next round when it was the last quest, skipping the round
  actions (date fix) unless a save is due or the quest goal is reached.

do_quest() now hands back the panel read that checked the last attempt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 2 commits October 30, 2026 07:53
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 1 PR #272.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the bbq/batch-quests branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant