Skip to content

BDSP AutoStory: route-plan golden + console-failure sim cases (#281) - #270

Merged
dayfine merged 19 commits into
bdsp/autostory-mine-floaroma-wipfrom
bdsp/autostory-route-plan-dump
Nov 9, 2026
Merged

dayfine merged 19 commits into
bdsp/autostory-mine-floaroma-wipfrom
bdsp/autostory-route-plan-dump

Conversation

@dayfine

@dayfine dayfine commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Adds a saved file of every BDSP story ROUTE step's planned legs, so planner or table changes show their plan diff in review, and carries #281 (console-failure sim cases), which was merged into this branch rather than the BDSP line.

Why #281 is here: #281 was stacked on this PR, so merging it put it in this branch (bdsp/autostory-route-plan-dump). Merging this PR lands it in bdsp/autostory-mine-floaroma-wip. Its code is unchanged from the #281 review.

Testing

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 17 commits November 8, 2026 16:19
01.05's open walk west to (2, 13), beside the Oreburgh Gate's mouth, slid
onto the warp (lab-B 2026-11-08, four runs). A table test plans every
ROUTE step as the walker does and fails on an open leg that may end on
the tile before a door it walks toward. It flagged 01.05's old
by_the_gate and four more: 00.03 above_the_door_again (now counted legs
from the west), 01.02 by_the_east_mouth and 01.05 through_the_gate (two
tiles short of the Gate's mouths, the taps go the rest), and 01.03
above_the_mine (two rows above the warp row, the door run goes on).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Moved unchanged out of StorySim_Tests.cpp, which is at the 1000-line
limit: r75's and r81's old cave exits and the old mine steps. The next
commit adds 01.05's old tap into the Oreburgh Gate beside them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
On lab-B (2026-11-08 15:31 to 15:54) 01.05's walk slid into the Oreburgh
Gate, and its tap step read the Gate's floor (about 46) as the fade and
waited 8 s for a banner already gone. A look after a tap is the fade only
when black (< 25) or a drop to dark from the look before the tap
(tap_faded()). A banner before the first tap means the walk before took
us through: the step ends with no tap. A tap step taps at most two past
the door its map has ahead, so one begun through the warp with its banner
gone fails a few tiles in, not across the Gate.

Tests: tap_faded() on the Gate's floor and real fades; the story sim's
01.05 tap step begun through the Gate's mouth, banner up and gone (red
before: 24 taps across the Gate); GridSim's part-tile offset taking the
warp on the old open walk west.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s stopgaps

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…y-route-plan-dump

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s start

On lab-B (2026-11-08 16:50, 01.08 below_the_ravaged_path) the leg
"west 2 (to wall)" from Route 204 (13, 2) stopped at once, 0 chunks moved:
the youngster who wanders (12, 2) to (14, 2) stood a tile ahead. The wait
for the way needed a stop three tiles short of the wall, so he was talked
to at once, and the replan from both (12, 2) and (13, 2) found no plan: an
uncertain start needs a wall both tiles reach, and no wall is anchored
from a tile someone wanders on.

A walk to the wall that never moved stopped where it began, so someone
stands on the next tile: it now waits for the way on short legs too, and
if they stay, the replan starts from the start tile alone with their tile
marked. Two Planned route tests replay the run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…l legs

On lab-B (2026-11-08, 01.08 below_the_ravaged_path) the plan "north 35
(to wall) to (13, 2), west 2 (to wall) to (11, 2)" walked along the row
Route 204 South's youngster wanders, (12..14, 2). He stopped the leg west
after 1 of 2 tiles; the check at the wall allowed a tile short on legs of
two or three tiles, so the route logged arriving at (11, 2) from (13, 2).

New tests, red on this commit:
- Route planner: a leg may cross a row zone (one tile of it) but not run
  along it (two tiles, the start among them); no plan when the row is the
  only way.
- Story table: every ROUTE step plans and none runs along a wander zone;
  01.08's plan walks at most one tile of (12..14, 2).
- Planned route: a 2-tile leg to a wall that ran out of time after 1 tile
  is a stop short of the wall, not the wall.

The two #271 tests that replayed the console's leg along the youngster's
row now replay it on a plain room: the planner will no longer plan it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…lk every tile

plan_robust_route() no longer uses a leg that walks two tiles in a row of
a zone where someone wanders (the leg's start among them): along a row
zone, or through a 2-D one. Crossing a row zone through one tile is still
planned at per_wander_tile, with #271's wait if he stands there. With no
other way there is no plan; nothing falls back.

A leg to a wall of 3 tiles or fewer that runs out of time short of its
tiles is now a stop short of the wall (talk, then plan again), and the
check at the wall needs every tile on such legs.

Plans that change: 01.08 below_the_ravaged_path goes up column 14, then
12, and crosses the youngster's row at (12, 2) only; 00.05b
below_the_tv_clown and 01.03 above_the_mine go round their wanderers.
The story sim now plans ROUTE steps as walk_route() does (from a wall for
a few start tiles, then default costs): from 01.03's two start tiles the
search over both ran out of budget on the longer way. The grid sim's wait
test crosses a row zone on a plain room, and Segment00Lines' reference
line for 00.03 goes along Route 201's row 13, above the Breeder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…le on line 7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…to Floaroma

Recovery from a few possible tiles pinned the wall with the fewest held
tiles and ignored the way on to the goal: after Taylor's battle on line 5
it held south 12 and walked 12 back where north 13 and 5 south would do.
It now plans the way on from every anchor and keeps the cheapest whole walk.

01.10's last line ran an open leg up column 11, which has no wall north;
a wild battle on it left no plan. The row now runs north until Floaroma's
banner, which ends the same from any tile of the column, and 01.11 starts
from the rows the run may stop on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ases as a table

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
lab-B 2026-11-08 18:41: 01.11's 8 taps west, then north, ended below the
old man and no one answered the old woman's talk. A grid sim test walks
01.11 to her from each of the nine tiles Floaroma's banner stops us on:
the old taps (OldStorySteps) must miss her from x 10 and 12, and the
table's walk must end below her from all nine.

The westedge batch found the field's edge 3 taps west of the old man,
a column west of Floaroma's map. SimGround adds that column beside the
map, for this test and for the story sim's 01.11 from now on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
8 taps west from where Floaroma's banner stops us (any of x 10..12) did not
end below the old woman: on lab-B (2026-11-08 18:41) they ended below the
old man. A walk west until the field's edge stops us ends on one column
from every arrival; from below the old man the edge is 3 taps west
(westedge batch 2026-11-08), so her column is 4 taps east of it.

That edge is x = -1, a column west of Floaroma's map. The map is left as
it is (a TODO in the table): the field may go on past it, or the old
couple may stand a tile east of their map points.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…-plan-dump

Conflict in PokemonBDSP_AutoStory_StoryTable_Tests.cpp: both sides reworked
the table walk the door test uses. Kept this branch's table_routes() and
plan_table_route() (the golden dump needs routes from unknown places and
the default-costs flag), and #277's plan_story_routes() now builds on them
for the door, wander-zone and youngster tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…#279

Rewritten with PA_UPDATE_ROUTE_PLANS=1 on the merged tree: the recovery
goal (#278) shortens several localizations, the wander-zone costs (#277)
reroute 00.05b and 01.08, and 01.10's line 7 and into_floaroma are no
longer ROUTE steps (#279).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine changed the base branch from bdsp/autostory-mine-floaroma-wip to bdsp/autostory-old-couple-clip November 9, 2026 03:20
… until fixed) (#281)

* BDSP AutoStory: move the story sim's executor out of its tests

SimStoryStepIO, SimExecutor and the run helpers move unchanged from
StorySim_Tests.cpp to Simulation/PokemonBDSP_AutoStory_StorySim.{h,cpp},
so other test files can run rows on the same simulation. The header
qualifies Pokemon:: names; the helpers that were file-local stay in an
anonymous namespace.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

* BDSP AutoStory: console failure cases on the story sim, known failing until fixed

Sim knobs (SimWorldKnobs, all off unless a case sets them):
- slides: an open leg's taps run on; onto a warp the walk sees the fade
  as it looks to its watchers (black: TRANSITION, dim: nothing, white: a
  wild battle), and the far map's banner is up or gone for the next step;
- floor and fade brightness per map, judged by the program's tap_faded();
- wanderers: everyone with a wander box on the maps walks it, seeded;
- late first lines for a talk.

SimFailureCases_Tests runs one case per console failure. Those the
program fails today are on KNOWN_FAILING with the change that is to fix
them; their tests pass while they still fail and fail once they pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from bdsp/autostory-old-couple-clip to bdsp/autostory-mine-floaroma-wip November 9, 2026 04:25
@dayfine dayfine changed the title BDSP AutoStory: golden dump of every story ROUTE step's planned legs BDSP AutoStory: route-plan golden + console-failure sim cases (#281) Nov 9, 2026
… into bdsp/autostory-route-plan-dump

#285 removed the sim-only Floaroma column (SimGround) and put 01.11's field
edge at x 0 on the real map. Keep this branch's StorySim.{h,cpp} layout and
drop every SimGround use there, in StorySim_Tests.cpp and SourceFiles.cmake.
StoryTable.cpp, GridSim_Tests.cpp and the StoryTable tests take #285's content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine marked this pull request as ready for review November 9, 2026 04:36
@dayfine
dayfine merged commit 6dc9f89 into bdsp/autostory-mine-floaroma-wip Nov 9, 2026
19 of 23 checks passed
@dayfine
dayfine deleted the bdsp/autostory-route-plan-dump branch November 9, 2026 04:36
dayfine added a commit that referenced this pull request Nov 9, 2026
…story-warp-events

GridSim walk_to_wall: keep both the scripted wall-leg wild battle count
(#255) and the warp fade report (#284).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 9, 2026
…/autostory-warp-events

The squash has the same tree as bdsp/autostory-route-plan-dump, merged
just before; the add/add conflicts keep this branch's side.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant