Repository navigation
Conversation
The round loop ran doable quests in panel order. R3 07:54 ran Make TM, then Catch any (failed), with Travel 500 m last; R3b 10:14 chose Auto Battle 10 with Travel 500 m on the board. order_quests_by_cost() sorts the quests to do by expected seconds per completion, from lab runs R3-R5: make-tm 79, travel-500 89, photo-swim 63/0.71, typed catch 137/0.75, hatch 190, sandwich 200, tera-self 153/0.59, auto-10 280. Quests without a measurement keep their places; ties keep panel order. run_bbq_rounds() orders each batch before running it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Give BBQRoundsScenario's `expected_attempted` a default member initializer (= {}), so
test cases that leave them out of a designated initializer compile on
the Windows Clang CI job.
That job builds with clang-cl /W4 /WX, which turns on
-Wmissing-designated-field-initializers: a designated initializer that
omits a field without a default member initializer is an error. Apple
clang's -Wextra does not enable that warning, so macOS builds miss it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/quest-order-by-cost
branch
from
October 23, 2026 04:25
0b1554c to
1ee923b
Compare
Owner
Author
|
Closing: superseded by ordering quests by expected BP per second (lab commit b46660d), which replaces cheapest-first. Tracked in the PR plan as part of the quest-policy PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior change: the order quests run in within a round.
Problem
The round loop ran the doable quests in panel order (roadmap A1). R3 07:54 ran Make TM, then Catch any (it failed), with Travel 500 m last; R3b 10:14 chose Auto Battle 10 with Travel 500 m on the board.
Change
order_quests_by_cost()sorts each batch by expected seconds per completion (time per attempt / success rate), a fixed table from lab runs R3-R5:Quests not in the table (catch-any, sneak-up, the other photos, ...) keep their places, and the measured ones are sorted among the places they hold; ties keep panel order.
run_bbq_rounds()orders the batch after the failed-quest filter, just before running it, and logs one line when the order changed.Tests
SimulatedBBQGameActionsnow records which quest eachdo_quest()call got;BBQRoundsScenariochecks it whenexpected_attemptedis set. 3 newPokemonSV::BBQFarmerRoundscases:1 case updated: "quest already gone counts as completed" (photo-swim, travel-500, make-tm) now runs make-tm first, then photo-swim, which also completes travel-500.
All 33 native BBQ cases pass (macOS arm64).
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E