Repository navigation
AutoStory: shared screen events and judges; BDSP and FRLG adapters (#268) - #290
Merged
dayfine merged 12 commits intoNov 9, 2026
Merged
Conversation
A game-agnostic vocabulary of what a story step sees (fades, location banner, dialog and choice boxes, interact prompt, battle start/end, player can move, screen still), an observer interface a game implements with its own detectors, and a run_until watcher form that records events and stops on chosen ones. The warp judgement (WarpSeen, fade_of) and the TalkOver judge from BDSP's #284/#289 move here, expressed over the events. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
BdspScreenObserver (the talk-over's SceneEyes, made public) reports BDSP's detectors as the shared screen events, and talk_over(), the walks and the story sim use the shared TalkOver judge, WarpSeen and fade_of instead of BDSP's own copies. Behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
FrlgScreenObserver maps the white dialog box, the selection box, the battle menu and battle text, and uniform fades to the shared events. Unit tests on synthetic frames; real frames are the detectors' own tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The battle text box detector reads a flat grey frame as its box; that frame is no real screen, so it tests nothing about the adapter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
ScreenEvents keeps its set operations; fades and the log text become free functions (fade_events, fade_in, describe), WarpSeen::see becomes note_warp(), and the tests use the case-table form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
marked this pull request as ready for review
November 9, 2026 07:48
dayfine
merged commit Nov 9, 2026
0d35443
into
bdsp/autostory-mine-floaroma-wip
19 of 23 checks passed
dayfine
added a commit
that referenced
this pull request
Nov 9, 2026
Moves #226's versions of these files into the PR that owns them. #226 commits: 0d35443 AutoStory: shared screen events and judges; BDSP and FRLG adapters (#268) (#290) 0192d6b BDSP AutoStory: a warp is a fade or a banner; walks report warps (#268 slices 1-3) (#284) 5493a9e BDSP AutoStory: routes never run along a wander zone; short wall legs walk every tile (#277) 71c3ed1 BDSP AutoStory: a wall leg that never moved waits, then plans from its start (#271) 0738cd5 BDSP AutoStory: 01.03 runs straight north up column 46 to the Center f2567a2 BDSP AutoStory: a battle on a counted leg's first tap re-plans to the step's end 65e145a BDSP AutoStory: a battle on a route leg's first input re-plans too a0d2204 BDSP walk: do not mark origin as preceding leg when movement moved chunks f9d253b BDSP AutoStory: tag late encounter origin unknown only when chunks moved <= 1 5a16268 BDSP AutoStory: soft cost penalty for wandering hazards and wall check safeguard 9a2eb0a BDSP AutoStory: avoid wandering NPC hazards and simulate wandering NPCs ac1ef0b BDSP AutoStory: align Oreburgh Mine maps, corridor legs, and Floaroma pathing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
bdsp/autostory-mine-floaroma-wip(#284 and #289 already merged there); the diff shows only this change. The shared part is also on branchautostory/screen-events-core(based onnav/story-steps), merged in here, so FRLG and PLZA branches can take it without BDSP.The perception pieces from #268 slices 1-4 (WarpSeen, fade_of, the TalkOver judge) lived in BDSP files, so FRLG and PLZA could not use them. This adds a game-agnostic
ScreenEventvocabulary and aScreenEventObserverinterface (plus aScreenEventWatcherforrun_until) inPokemon/AutoStory, moves the warp and talk-over judges there over those events, and makes BDSP (BdspScreenObserver, the talk-over's former SceneEyes) and FRLG (FrlgScreenObserver: white dialog, selection box, battle menu/text, fades) the first adapters. BDSP behaviour is unchanged: PokemonBDSP::AutoStory is 144 passed / 0 failed / 7 skipped before and after; the shared story tests went from 75 to 80 passed (new Pokemon::ScreenEvents), and PokemonFRLG gains 3 passing adapter tests (the other FRLG and PLZA image tests fail locally only for lack of CommandLineTests images, same as before).Moved unchanged into
Pokemon_ScreenEvents.{h,cpp}/Pokemon_SceneJudges.{h,cpp}:WarpFade,fade_of,WarpSeen,describe(WarpSeen)fromPokemonBDSP_AutoStory_Walk, and theTalkOverjudge fromPokemonBDSP_AutoStory_TalkOver(now readingScreenEventsinstead ofSceneLook); seegit diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change bdsp/autostory-mine-floaroma-wip...autostory/perception-events.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss