Repository navigation
PokemonSV AutoStory: shared checkpoint range options and log lines - #320
Merged
dayfine merged 3 commits intoNov 13, 2026
Merged
Conversation
This was referenced Nov 10, 2026
The tutorial and main story checkpoint dropdowns are now the shared StoryRangeOptions, added under the same keys (START_CHECKPOINT_TUTORIAL, END_CHECKPOINT_TUTORIAL, START_CHECKPOINT_MAINSTORY, END_CHECKPOINT_MAINSTORY) over the same databases, so saved settings load unchanged; the end stays unlocked while running. The start-before-end check is the range's. The checkpoint loops log the shared attempt and reset lines, and the run logs the shared checkpoint start line. Rebased onto autostory/story-range-options (#325) and squashed: it uses only the shared range options (#325) and log lines (#45), not #312. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
force-pushed
the
sv/autostory-shared-story-options
branch
from
November 12, 2026 04:37
f3a8799 to
9ea62b9
Compare
dayfine
changed the base branch from
nav/story-engine
to
autostory/story-range-options
November 12, 2026 04:38
dayfine
commented
Nov 12, 2026
| if (get_start_checkpoint_index() > get_end_checkpoint_index()){ | ||
| throw UserSetupError(env.logger(), "The start checkpoint cannot be later than the end segment."); | ||
| if (!checkpoint_range().check_validity().empty()){ | ||
| throw UserSetupError(env.logger(), checkpoint_range().check_validity()); |
Owner
Author
There was a problem hiding this comment.
if (error_message = checkpoint_range().check_validity(); !error_message.empty()) {
throw UserSetupError(env.logger(), error_message);
}
| #include "ML/Inference/ML_YOLONavigation.h" | ||
| #include "NintendoSwitch/NintendoSwitch_SingleSwitchProgram.h" | ||
| #include "Pokemon/AutoStory/Pokemon_AutoStoryStats.h" | ||
| #include "Pokemon/AutoStory/Pokemon_StoryLog.h" |
Owner
Author
There was a problem hiding this comment.
is this include used here?
Owner
Author
There was a problem hiding this comment.
oh based on IWYU - should this header be added to the .cpp file?
…tory-options Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…tory-options Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #325; for upstream later. Base
autostory/story-range-options, so the diff shows only this change.SV's AutoStory kept its own four checkpoint start/end dropdowns and its own free-text checkpoint log lines. This makes the tutorial and main story checkpoint dropdowns two shared
StoryRangeOptionsfrom #312, added under the same option keys (START_CHECKPOINT_TUTORIAL,END_CHECKPOINT_TUTORIAL,START_CHECKPOINT_MAINSTORY,END_CHECKPOINT_MAINSTORY) over the same databases, so saved settings load unchanged and need no migration; the end dropdowns stay unlocked while running, and the start-before-end check is the range's. The checkpoint loops now log the shared[Checkpoint] <name>: attempt Nandfailed, resetting for attempt Nlines (attempts count from 1), and the run logs the shared checkpoint start line; the section and segment dropdowns are unchanged. Tested by building the app and running the Pokemon:: suites on the headless runner; SV has no AutoStory unit tests.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss