Skip to content

PokemonSV AutoStory: shared checkpoint range options and log lines - #320

Merged
dayfine merged 3 commits into
autostory/story-range-optionsfrom
sv/autostory-shared-story-options
Nov 13, 2026
Merged

dayfine merged 3 commits into
autostory/story-range-optionsfrom
sv/autostory-shared-story-options

Conversation

@dayfine

@dayfine dayfine commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Depends on #325; for upstream later. Base autostory/story-range-options, so the diff shows only this change.

SV's AutoStory kept its own four checkpoint start/end dropdowns and its own free-text checkpoint log lines. This makes the tutorial and main story checkpoint dropdowns two shared StoryRangeOptions from #312, added under the same option keys (START_CHECKPOINT_TUTORIAL, END_CHECKPOINT_TUTORIAL, START_CHECKPOINT_MAINSTORY, END_CHECKPOINT_MAINSTORY) over the same databases, so saved settings load unchanged and need no migration; the end dropdowns stay unlocked while running, and the start-before-end check is the range's. The checkpoint loops now log the shared [Checkpoint] <name>: attempt N and failed, resetting for attempt N lines (attempts count from 1), and the run logs the shared checkpoint start line; the section and segment dropdowns are unchanged. Tested by building the app and running the Pokemon:: suites on the headless runner; SV has no AutoStory unit tests.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

The tutorial and main story checkpoint dropdowns are now the shared
StoryRangeOptions, added under the same keys (START_CHECKPOINT_TUTORIAL,
END_CHECKPOINT_TUTORIAL, START_CHECKPOINT_MAINSTORY, END_CHECKPOINT_MAINSTORY)
over the same databases, so saved settings load unchanged; the end stays
unlocked while running. The start-before-end check is the range's. The
checkpoint loops log the shared attempt and reset lines, and the run logs
the shared checkpoint start line.

Rebased onto autostory/story-range-options (#325) and squashed: it
uses only the shared range options (#325) and log lines (#45), not #312.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine force-pushed the sv/autostory-shared-story-options branch from f3a8799 to 9ea62b9 Compare November 12, 2026 04:37
@dayfine
dayfine changed the base branch from nav/story-engine to autostory/story-range-options November 12, 2026 04:38
if (get_start_checkpoint_index() > get_end_checkpoint_index()){
throw UserSetupError(env.logger(), "The start checkpoint cannot be later than the end segment.");
if (!checkpoint_range().check_validity().empty()){
throw UserSetupError(env.logger(), checkpoint_range().check_validity());

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (error_message = checkpoint_range().check_validity(); !error_message.empty()) {
throw UserSetupError(env.logger(), error_message);
}

#include "ML/Inference/ML_YOLONavigation.h"
#include "NintendoSwitch/NintendoSwitch_SingleSwitchProgram.h"
#include "Pokemon/AutoStory/Pokemon_AutoStoryStats.h"
#include "Pokemon/AutoStory/Pokemon_StoryLog.h"

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this include used here?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh based on IWYU - should this header be added to the .cpp file?

dayfine and others added 2 commits November 11, 2026 21:38
…tory-options

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…tory-options

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine merged commit 3429101 into autostory/story-range-options Nov 13, 2026
10 checks passed
@dayfine
dayfine deleted the sv/autostory-shared-story-options branch November 13, 2026 03:30
@dayfine

dayfine commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

Folded into #325 (merge 3429101).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant