Repository navigation
FRLG story replay: read the capture in #312's step format after stage 7's JSON - #339
Merged
Merged
Conversation
…ction/args steps The FRLG stack stopped building after #312: the C++ rows set step.target, legs, direction, fight_wild and may_lose directly, StoryChecks became StoryCheckLevel, Pokemon_StorySteps.h moved to Pokemon_StoryStepExecutor.h and the JSON codecs to Data/. - Each checkpoint is StoryData/frlg-<id>.plan.json (pokesim-authored- checkpoint/1), read with read_authored_checkpoint() against FRLG's actions: the built-in ones plus ROUTE/LEGS "run". The parser fills in the fallbacks (fight_wild, may_lose, yes), so the files give only what differs. FRLG's execution object carries the START menu, the supplies, the lead after Brock and the notes that were C++ comments. - The executor, the step-table, sim and route tests read typed args (story_arg<T>()); the sim's fake game dispatches by kind in run(). - Check levels: DEFAULT and above check the screen as THOROUGH did; FAST and SPEEDRUN trust counts as FAST did. - AutoStory: StoryRunOptions with the FRLG languages, the check level and language into StoryEnv, record_story_counts(). The old C++ rows stay in PokemonFRLG_AutoStoryTableParity_Tests.cpp for this commit only: each file loads to the same steps, args, poses, supplies and START menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The previous commit's parity test passed: every StoryData file loads to its old C++ row. The rows and the test go; StoryData/ is the table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s JSON Stage 1 moved 00.01-00.10 into StoryData/ on #312's action/args steps. Stage 2's own rows follow it: - 00.01 (handoff sid_helper, the new intro why), 00.01b (live start, the GAME step close_trainer_card), 00.04 (to the ball, handoff starter_rng) and 00.04b are files; FRLG's execution object reads "handoff" and "live_start". - close_trainer_card is an FRLG GAME action with no args; StoryExecutor's GAME action dispatches on step.action instead of overriding the old per-kind game(). - AutoStory: check level and language into StoryEnv, record_story_counts(); the run-plan tests convert the start GridPose. The C++ rows stay in PokemonFRLG_AutoStoryTableParity_Tests.cpp for this commit only, and every file loads to its row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The merge's parity test passed: every StoryData file, 00.01b and the 00.04/00.04b split included, loads to its C++ row. The rows and the test go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
FRLG AutoStory stage 2: 00.01b and the 00.04 split as JSON
… JSON Stage 3 ported to #312's action/args steps, its checkpoints moved into StoryData/ the way #330 and #331 moved stages 1 and 2. - 00.11, 00.12, 00.12b, 00.12c and 00.13 are files, and 00.10 gains its walk to below Pewter's Center. Each carries "metadata": {"phase": "testing"}, which FRLG's reader checks and strips before the shared one. - FRLG's GAME actions declare typed args in place of the variant strings: pc (do, slot, box, if_present), capture, fossil, level, mart, teach and grind (whose nurse is now its "nurse" arg), plus leave_gift_summary. Their specs are in story_action_specs(); the step table binds each to the GAME action with its args. VariantWords became GameArgs. - The execution object's handoff takes gift_rng. The old C++ rows stay in PokemonFRLG_AutoStoryTableParity_Tests.cpp for this commit only: every file loads to the same steps, args, poses, supplies and START menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The parity test passed on the merge before this commit: every StoryData file through 00.13 loads to the C++ row it replaces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
FRLG AutoStory stage 3: 00.10-00.13 as JSON, GAME steps with typed args
… as JSON Stage 4's checkpoints 00.14 to 00.16 (with 00.14b, 00.14c and 00.15b) as StoryData files in the #312 step format, each marked "phase": "testing". The STEP "trainer_line" action is a spec, Mart and TEACH steps load as once per save, and stage 4's tests read steps through their args. A parity test checks the files load to the C++ rows they replace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The parity test passed in the merge before this commit: every story file loads to the C++ row it replaces. The rows went with the merge's Table.cpp; this removes the parity test that held them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
FRLG AutoStory: stage 4's checkpoints as JSON
…ws as JSON Stage 5's checkpoints 00.17 to 00.20, and 00.14's Mega Kick tutor, as StoryData files in the #312 step format, each marked "phase": "testing". TEACH takes the tutor as its item; pacing and the walk back after a trainer's battle read the GRIND's or capture's args. A parity test checks the files load to the C++ rows they replace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The parity test passed in the merge before this commit: every story file loads to the C++ row it replaces. This removes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
FRLG AutoStory: stage 5's checkpoints as JSON
…s JSON Stage 6's checkpoints 00.21 to 00.25 as StoryData files in the #312 step format, each marked "phase": "testing". The row-building TableSteps and TableVermilionGym files go with the C++ rows. Cut, the trash cans, the trainer wait and the GRIND check are action specs; a GAME action with its own row keeps that row's console action. The row sims and stage 6's tests read step args. A parity test checks the files load to the C++ rows they replace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The parity test passed in the merge before this commit: every story file loads to the C++ row it replaces. This removes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
FRLG AutoStory: stage 6's checkpoints as JSON
…ows as JSON Stage 7's checkpoints 00.26 and 00.27 as StoryData files in the #312 step format, each marked "phase": "testing". The Celadon and TableSteps rows go with the C++ rows. Stage 7's own JSON pilot (Data/JsonParser, the Parcel capture and plan, its README and the Parcel sim test) is dropped for the one reader in PokemonFRLG_AutoStoryTable; Data/JsonWriter and its export tests stay. step_onto() is a hop: a STEP with a direction and a declared end. A parity test checks the files load to the C++ rows they replace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The parity test passed on the merge before this commit: every StoryData file through 00.27 loads to the C++ row it replaces. The row tests' registrations move to PokemonFRLG_AutoStoryRows_Tests.h and Viridian's SHOP step to PokemonFRLG_AutoStoryViridianMart, which keeps the story table header and the events file within their size limits; the shop is moved unchanged but for reading its args through story_arg. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
FRLG AutoStory: stage 7's rows as JSON (00.26, 00.27)
…play reads #312 steps Stage 7 now reads its rows from StoryData in the #312 step format and has one checkpoint reader, without the legacy export reader or the Parcel capture the replay read. The replay keeps the capture's exact bytes as ReplayData/capture.json, which binding.json pins, and reads its checkpoint in the step format: a route's target and a step's direction (north where the export left the default out) become args. The executor reads targets, directions and poses through story_arg and pose_of; its report gives the engine's pose as a grid pose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
marked this pull request as ready for review
November 10, 2026 19:24
dayfine
added a commit
that referenced
this pull request
Nov 11, 2026
#339 moved StoryData/frlg-parcel-00.05.json to ReplayData/capture.json (same bytes); the replay-verify step still read the old path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #258 (base
frlg/checkpoint-replay, withfrlg/stage7-celadonand #338 merged in).#258 has no story rows of its own, but its replay read the Parcel capture through stage 7's legacy export reader and the old step fields, both gone since #338. This merges stage 7 in and moves the replay onto #312's step format.
ReplayData/capture.jsonholds the capture's exact bytes (the SHA-256binding.jsonpins is unchanged); the replay no longer looks for it inStoryData/.targetand a step'sdirectionbecome args (a step without one gets the old default, north), and poses become grid poses. Its native fields aren't read; the replay runs the common checkpoint only.story_arg/pose_of; the report'sengine_poseis now a grid pose (or null).devtools/story-export/frlg_main.cppstill includes the oldPokemonFRLG_AutoStoryExport.h(stage 7 moved it toData/JsonWriter.h); it is behind an off-by-default option and left for its owner.Testing: full build;
--command-line-test-mode --profile unit-tests: the 18StoryReplaycases pass, andPokemonFRLG::AutoStory*/Pokemon::Story*pass apart from the same 12 FileException image tests. Code health againstfrlg/checkpoint-replay: 0 failures. Nothing ran on a console.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss