Skip to content

FRLG: detectors for AutoStory - #346

Draft
dayfine wants to merge 13 commits into
autostory/enginefrom
frlg/detectors
Draft

dayfine wants to merge 13 commits into
autostory/enginefrom
frlg/detectors

Conversation

@dayfine

@dayfine dayfine commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Depends on #332 (base autostory/engine; the diff shows only this change)

The FRLG AutoStory stack added its screen detectors and readers piecemeal across stages 1 to 8, so each stage PR's diff mixed them with story code. This PR collects every FRLG Inference file the stack adds or changes, at its latest version from frlg/stage8-rocktunnel: the battle screen, text box, HP bar and flash detectors, the naming screen detector, the item list, option menu, save card, summary moves and teach screen readers, the PC screen reader, the white dialog detector and the trainer ID reader's changes, with their image tests registered in PokemonFRLG_Tests.cpp. For code health, names and OCR dictionaries use std::string_view instead of char*, a few helpers used only inside their reader became internal, and TeachText moved to PokemonFRLG_TeachTextReader.h (included by the teach screen reader's header); there is no behaviour change. Built on macOS on its own on top of nav/story-steps; the FRLG and Pokemon:: unit tests pass, and the image tests fail locally only because the CommandLineTests images are not checked out.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 5 commits November 10, 2026 14:00
Every FRLG Inference file the AutoStory stack adds or changes, at its latest
version (frlg/stage8-rocktunnel): the battle screen, text box, HP bar and flash
detectors, the naming screen detector, the item list, option menu, save card,
summary moves and teach screen readers, the PC screen reader, the white dialog
detector and the trainer ID reader's changes. Their image tests are registered
in PokemonFRLG_Tests.cpp.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Code health on the detectors: names and dictionaries use std::string_view
instead of char*; the TM case and item menu row counts, read_key_item() and
read_tm_case_move() and the summary move boxes are internal to their .cpp;
TeachText and its reader move to PokemonFRLG_TeachTextReader.h (included by
the teach screen reader's header); the white dialog detector's tests register
through add_tests_AdvanceWhiteDialogDetector(). No behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Code health's string_concat and out_param_order rules: the image tests'
names, paths and filename errors are built with std::format, and the teach
screen test's add_list() takes its outputs last. No behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine changed the base branch from nav/story-steps to nav/grid-story-steps November 11, 2026 09:13
dayfine and others added 2 commits November 11, 2026 21:40
Conflict in PokemonFRLG_Tests.cpp's registration list: main's sorted list plus this branch's suites; AutoStoryScreenEvents stays registered once, through add_tests_AutoStoryReaders().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests (engine carries it); keep this branch's reader and detector tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine changed the base branch from nav/grid-story-steps to autostory/engine November 14, 2026 01:59
dayfine and others added 5 commits November 13, 2026 20:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonFRLG/PokemonFRLG_Tests.cpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant