Repository navigation
Conversation
Every FRLG Inference file the AutoStory stack adds or changes, at its latest version (frlg/stage8-rocktunnel): the battle screen, text box, HP bar and flash detectors, the naming screen detector, the item list, option menu, save card, summary moves and teach screen readers, the PC screen reader, the white dialog detector and the trainer ID reader's changes. Their image tests are registered in PokemonFRLG_Tests.cpp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Code health on the detectors: names and dictionaries use std::string_view instead of char*; the TM case and item menu row counts, read_key_item() and read_tm_case_move() and the summary move boxes are internal to their .cpp; TeachText and its reader move to PokemonFRLG_TeachTextReader.h (included by the teach screen reader's header); the white dialog detector's tests register through add_tests_AdvanceWhiteDialogDetector(). No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Code health's string_concat and out_param_order rules: the image tests' names, paths and filename errors are built with std::format, and the teach screen test's add_list() takes its outputs last. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 10, 2026
dayfine
changed the base branch from
nav/story-steps
to
nav/grid-story-steps
November 11, 2026 09:13
Conflict in PokemonFRLG_Tests.cpp's registration list: main's sorted list plus this branch's suites; AutoStoryScreenEvents stays registered once, through add_tests_AutoStoryReaders(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests (engine carries it); keep this branch's reader and detector tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
changed the base branch from
nav/grid-story-steps
to
autostory/engine
November 14, 2026 01:59
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss # Conflicts: # SerialPrograms/Source/VideoGames/PokemonFRLG/PokemonFRLG_Tests.cpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #332 (base autostory/engine; the diff shows only this change)
The FRLG AutoStory stack added its screen detectors and readers piecemeal across stages 1 to 8, so each stage PR's diff mixed them with story code. This PR collects every FRLG Inference file the stack adds or changes, at its latest version from frlg/stage8-rocktunnel: the battle screen, text box, HP bar and flash detectors, the naming screen detector, the item list, option menu, save card, summary moves and teach screen readers, the PC screen reader, the white dialog detector and the trainer ID reader's changes, with their image tests registered in PokemonFRLG_Tests.cpp. For code health, names and OCR dictionaries use std::string_view instead of char*, a few helpers used only inside their reader became internal, and TeachText moved to PokemonFRLG_TeachTextReader.h (included by the teach screen reader's header); there is no behaviour change. Built on macOS on its own on top of nav/story-steps; the FRLG and Pokemon:: unit tests pass, and the image tests fail locally only because the CommandLineTests images are not checked out.
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss