Repository navigation
Conversation
At the boss battle, a battle-screen read that is not a single boss species now triggers the summary read, so a rental misread no longer leaves the boss empty. BossFinder falls back to the normal ball for an empty or unknown boss instead of throwing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Add GlobalState::opponent_fits_stage() and use it in accept_opponent() and process_header_read(), so a read that does not fit the battle stage falls back to the summary read. boss_if_caught() returns the boss only after the fourth win. throw_balls() uses the normal ball when the boss is unknown, so BossFinder stays unchanged from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ll be empty Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
commented
Nov 11, 2026
|
|
||
| bool boss = inferred.wins == 4; | ||
| if (boss){ | ||
| // Still crashes (BossFinder throws on an empty boss) if no battle-screen |
Owner
Author
There was a problem hiding this comment.
This will crash if inferred.boss is still empty after battle-screen and the fallback summary read (OCR misses)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base
main; independent, the diff shows only this change.Following PokemonAutomation#1851, a rental misread at the Max Lair boss battle no longer becomes the boss, but it left the boss empty, and BossFinder then threw "Unrecognized boss slug" when picking the boss ball on the fourth win. The new
GlobalState::opponent_fits_stage()says whether a read fits the battle stage (no boss before the boss battle; at the boss battle, the known boss, or a single boss species while none is known);process_header_readreturns it, so a read that does not fit falls back to the summary read, andaccept_opponent()records the boss only from a fitting read.boss_if_caught()now returns the boss only after the fourth win, BossFinder is unchanged from main; a comment at the boss ball call notes it can still throw if no read in the boss battle ever gave a boss species. Tested with the MaxLair state suite (boss-state and new fits-stage cases, former TODO cases now at their correct expectations) in the headless SerialProgramsTests runner (--filter MaxLair); nothing was run on a console.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss