Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
8b656d1
FRLG story drafts 00.29-00.31: Lavender to the Silph Scope
dayfine Nov 9, 2026
9fb268c
Merge remote-tracking branch 'origin/frlg/stage8-rocktunnel' into frl…
dayfine Nov 10, 2026
5a1c770
FRLG drafts: drop the 00.29 draft for #293's row; say why 00.30-00.31…
dayfine Nov 10, 2026
cf9400f
FRLG overworld: spinner tiles, the lift's floor and the poster switch…
dayfine Nov 10, 2026
5ca3d8f
FRLG AutoStory: lift floor and poster switch steps; the Rocket Hideou…
dayfine Nov 10, 2026
cf123e7
FRLG AutoStory: use items from the bag, renew a Repel, ride the Bicycle
dayfine Nov 10, 2026
a078ce6
FRLG AutoStory: mark the sim bag's use_row override
dayfine Nov 10, 2026
620d6ce
FRLG: code health: field actions in their own file, route tests in a …
dayfine Nov 10, 2026
ce645d1
FRLG: route tests find maps without the route's internals
dayfine Nov 10, 2026
fd9f6b9
FRLG drafts: restore Lavender to Celadon as 00.30, hideout as 00.31-0…
dayfine Nov 10, 2026
8ebc21b
FRLG: script Pokemon Centers and the hideout lift; code spinners and …
dayfine Nov 10, 2026
6927208
FRLG AutoStory: every story checkpoint as an authored JSON plan
dayfine Nov 10, 2026
2c370c9
FRLG AutoStory: load the story table from its authored plans only
dayfine Nov 10, 2026
3dcf3e8
FRLG AutoStory: code health for the authored story tests
dayfine Nov 10, 2026
c182c90
Merge remote-tracking branch 'origin/frlg/stage8-rocktunnel' into frl…
dayfine Nov 10, 2026
33e902b
Merge remote-tracking branch 'origin/frlg/draft-story-29-31' into frl…
dayfine Nov 10, 2026
2162103
FRLG AutoStory 00.30: Lavender Town to Celadon City as an authored plan
dayfine Nov 10, 2026
ddb1e72
FRLG AutoStory 00.30: the story-wide tests count 00.30
dayfine Nov 10, 2026
125c19f
FRLG AutoStory 00.30: Gamer Rich in the story's trainers
dayfine Nov 10, 2026
4a187aa
Merge frlg/stage8-rocktunnel into frlg/story-json
dayfine Nov 10, 2026
43d1e50
Story JSON: keep story_step_json() and event_log_line() within code h…
dayfine Nov 10, 2026
b7c9dfa
Merge frlg/story-json into frlg/story-0030
dayfine Nov 10, 2026
c5ee094
FRLG walker: no turn tap on the Bicycle
dayfine Nov 10, 2026
234d0b5
Merge remote-tracking branch 'origin/frlg/story-0030' into frlg/bike-…
dayfine Nov 10, 2026
e615aaa
FRLG walker: keep the bike change inside the file and function limits
dayfine Nov 10, 2026
c35b683
FRLG AutoStory: GAME steps carry their arguments in args
dayfine Nov 10, 2026
2167bbd
Merge frlg/story-json into frlg/story-0030
dayfine Nov 10, 2026
f7273a8
FRLG AutoStory: 00.30's GAME steps, use_item and lift_floor carry args
dayfine Nov 10, 2026
2f99919
FRLG walker: the Bicycle moves a tile per 100ms
dayfine Nov 10, 2026
7aff29c
FRLG AutoStory: sim test for 00.30's Route 8 walk from a start off by 3
dayfine Nov 10, 2026
87f2e85
FRLG AutoStory: 00.30 re-anchors on Route 8's walls before the door
dayfine Nov 10, 2026
83d3be7
FRLG walker: count open Bicycle legs in taps, get on with SELECT
dayfine Nov 10, 2026
0a9bb40
FRLG AutoStory: register the Bicycle in 00.30, ride_bike presses SELECT
dayfine Nov 10, 2026
388bfff
FRLG walker: code health for the Bicycle taps; register_bike's trace …
dayfine Nov 10, 2026
606d428
FRLG walker: the Bicycle tap API in its own header; linter fixes
dayfine Nov 10, 2026
b062392
FRLG AutoStory: red sim test, a capture started on the Bicycle drifts…
dayfine Nov 10, 2026
d2504dd
FRLG AutoStory: pace for a capture or grind on foot, from where the l…
dayfine Nov 10, 2026
cbf3354
FRLG AutoStory: qualify OverworldWalkSteps::BikeSelectCalls in pacing
dayfine Nov 10, 2026
6c658e9
FRLG AutoStory: the pacing search in its own header, AutoStoryPacing.h
dayfine Nov 10, 2026
acc74a7
PokemonFRLG: Split over-limit headers, drop char* for code health
dayfine Nov 10, 2026
1d619d9
FRLG AutoStory 00.31: Celadon Game Corner to the Rocket Hideout's LIF…
dayfine Nov 10, 2026
21861ce
FRLG AutoStory: the fault sweep's trainer hiding in its own function,…
dayfine Nov 10, 2026
3ed6b4c
FRLG Overworld: red sim test, a short first leg off the Rocket Hideou…
dayfine Nov 10, 2026
9da5d77
FRLG Overworld: check open legs whose wall holds and way back walk up…
dayfine Nov 10, 2026
e81230c
FRLG Overworld: the B3F short-leg sim test in the spinner tests, keep…
dayfine Nov 10, 2026
9562615
FRLG Overworld: the open-leg check's tiles-per-tile limit in the .cpp…
dayfine Nov 10, 2026
3484975
FRLG Overworld: check an open leg before a step onto a spinner
dayfine Nov 10, 2026
f23905d
FRLG AutoStory 00.31: B3F's arrow floor as pokeguy's legs, a checked …
dayfine Nov 10, 2026
6f3974e
fixup: no ms literal
dayfine Nov 10, 2026
9cb0488
FRLG AutoStory: LEGS take the taps variant
dayfine Nov 10, 2026
515782a
FRLG AutoStory: three step taps per tile, the run check skips taps legs
dayfine Nov 10, 2026
ada1353
FRLG AutoStory 00.31: the golden trace with the taps legs; the B3F ta…
dayfine Nov 10, 2026
fcde135
FRLG AutoStory 00.31: golden trace from the old one, only 00.31 chang…
dayfine Nov 10, 2026
ab60d97
FRLG AutoStory: fixed_route in its own file, AutoStoryLegs.cpp, keepi…
dayfine Nov 10, 2026
421a651
FRLG AutoStory: TAPS_VARIANT and fixed_route() in AutoStoryLegs.h, of…
dayfine Nov 10, 2026
5ba4c26
FRLG AutoStory: JsonParser includes AutoStoryLegs.h; AutoStory_Tests …
dayfine Nov 10, 2026
62e1ced
FRLG AutoStory: close JsonParser's AutoStoryLegs.h include
dayfine Nov 10, 2026
bd86cf7
FRLG AutoStory: Lavender tests include AutoStoryLegs.h
dayfine Nov 10, 2026
953bb8c
FRLG AutoStory 00.32: the Rocket Hideout's lift, door guards, Giovann…
dayfine Nov 10, 2026
d285f93
FRLG AutoStory 00.32: the story maps without B2F's MOON STONE ball; t…
dayfine Nov 10, 2026
cccd2fa
FRLG AutoStory 00.32: the row on the sim, the golden trace's 00.32 li…
dayfine Nov 10, 2026
545d66c
FRLG AutoStory 00.32: no short-hold sweep onto B3F's stairs, which th…
dayfine Nov 10, 2026
eccc565
FRLG overworld: one more step into a warp when its fade doesn't come
dayfine Nov 10, 2026
37b8021
FRLG overworld sim: keep OverworldSim.cpp within 1000 lines
dayfine Nov 10, 2026
17ff2a4
FRLG AutoStory 00.32: step on into arrow warps; tap up to row 17
dayfine Nov 10, 2026
e2ce441
FRLG AutoStory 00.32: keep the warp retry within the code-health limits
dayfine Nov 10, 2026
4854152
FRLG AutoStory 00.32: tap every open-floor walk on the hideout floors
dayfine Nov 10, 2026
212a1eb
FRLG AutoStory 00.32: judge a tap's step on all four edge bands
dayfine Nov 10, 2026
55ff73b
FRLG AutoStory 00.31: a talk fails unless A opens a message
dayfine Nov 10, 2026
3f53ca1
FRLG AutoStory 00.31: keep the talk check beside its step
dayfine Nov 10, 2026
7995c3e
Merge branch 'frlg/story-0031-tmp' into frlg/story-0032-tmp
dayfine Nov 10, 2026
5fb0054
FRLG AutoStory 00.31: tap B4F's open floor after the LIFT KEY
dayfine Nov 10, 2026
ff26c6b
Merge branch 'frlg/story-0031' into frlg/story-0032
dayfine Nov 10, 2026
d9190da
FRLG overworld: confirm a warp's destination after its fade
dayfine Nov 10, 2026
17c8115
FRLG overworld: keep warp confirmation within code health limits
dayfine Nov 10, 2026
7ac4b0a
Merge branch 'frlg/story-0031' into frlg/story-0032
dayfine Nov 10, 2026
ed2f97c
FRLG hideout: red test for a blocked tap beside B2F's arrow
dayfine Nov 11, 2026
f02c160
FRLG overworld: a spinner ahead of a blocked tap is no wall
dayfine Nov 11, 2026
5f08240
FRLG hideout test: std::format for the failure message
dayfine Nov 11, 2026
ca60cff
FRLG hideout: tap the spinner mazes blind
dayfine Nov 11, 2026
e2a5cc2
FRLG hideout: blind taps' inputs first, std::format
dayfine Nov 11, 2026
cb72a20
FRLG hideout: lift exit confirmed without a black fade
dayfine Nov 11, 2026
7c1a3f1
FRLG rooms: name RoomLeg fields; one anonymous namespace in Overworld…
dayfine Nov 11, 2026
1b33ad6
Merge pull request #359 from dayfine/frlg/fix-b2f-spin-replan
dayfine Nov 11, 2026
c5f78c9
FRLG AutoStory: number checkpoints by Bulbapedia walkthrough part
dayfine Nov 11, 2026
87fac08
FRLG replay fixtures: re-hash binding and route candidate for 02.01
dayfine Nov 11, 2026
5f15ed2
FRLG Vermilion Gym tests: string_view ids
dayfine Nov 11, 2026
b9dde10
FRLG AutoStory: pin PokemonSimulation d3eea1b with Parcel as 02.01
dayfine Nov 11, 2026
220a483
FRLG AutoStory: number checkpoints by Bulbapedia walkthrough part
dayfine Nov 11, 2026
a23d116
Merge frlg/part-ids-stage8: move the renumbering onto frlg/stage8-roc…
dayfine Nov 11, 2026
c82be2c
Merge remote-tracking branch 'origin/frlg/stage8-rocktunnel' into frl…
dayfine Nov 11, 2026
5a6529d
CI: restore part-ids workflow hunks lost in the stage8 merge (replay …
dayfine Nov 11, 2026
cc1356c
Merge origin/frlg/stage8-rocktunnel into frlg/part-ids
dayfine Nov 11, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/cpp-ci-serial-programs-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
uses: actions/checkout@v7
with:
repository: dayfine/PokemonSimulation
ref: bdca47c5045797be1d2a1f0931ad6a8f15ab3225
ref: d3eea1b5c04180f8b60eb98b0d65f70aca6b1abb
path: StoryReplaySource

- name: Verify replay preview bytes and independently regenerate its route input
Expand Down Expand Up @@ -279,12 +279,12 @@ jobs:
if: startsWith(inputs.os, 'ubuntu') && inputs.run-tests
run: |
cd Arduino-Source/SerialPrograms/bin
cp ../Source/VideoGames/PokemonFRLG/Programs/AutoStory/StoryData/frlg-00.05.plan.json frlg-parcel.native.json
cp ../Source/VideoGames/PokemonFRLG/Programs/AutoStory/StoryData/frlg-02.01.plan.json frlg-parcel.native.json
python3 - <<'PYTHON'
import json
from pathlib import Path
data = json.loads(Path('frlg-parcel.native.json').read_text())
assert data['game'] == 'frlg' and data['checkpoint']['id'] == '00.05'
assert data['game'] == 'frlg' and data['checkpoint']['id'] == '02.01'
assert len(data['checkpoint']['events']) == 3
PYTHON

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Teach Screen Reader

Check warning on line 1 in SerialPrograms/Source/VideoGames/PokemonFRLG/Inference/Menus/PokemonFRLG_TeachScreenReader.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

<file>: file_lines=555 (advisory above 500, limit 1000)
*
* From: https://github.com/PokemonAutomation/
*
Expand Down Expand Up @@ -541,7 +541,7 @@
"KnownMoves_eng.png",
"StopQuestion_eng.png",
"DidNotLearn_eng.png",
// HM01 to an Oddish with two free slots (00.23, console B).
// HM01 to an Oddish with two free slots (06.02, console B).
"MachineSet_eng.png",
}){
database.add<Test_TeachScreen>(std::format("PokemonFRLG/TeachScreenReader/{}", image));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace MovementMechanics{
// tiles, the same each time: a tile per 100ms, so an open leg's hold of
// (n - 1) tiles and a half moves n. 112ms a tile (a wall-to-wall time
// of the motion on screen) held "west 16 (open)" for 17 or 18 tiles on
// Route 8 (00.30 run 2). Not the decompilation's 4 frames a tile (67ms):
// Route 8 (08.03 run 2). Not the decompilation's 4 frames a tile (67ms):
// the bike speeds up from rest.
inline constexpr Milliseconds BIKE_TILE_TIME(100);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* tap's start is ignored.
* - Taps with no release between them are one hold: after a turn, 3 of
* them took 0 or 1 steps.
* After a battle (console B, 2026-11-09 15:50, 00.28 winston_line): a
* After a battle (console B, 2026-11-09 15:50, 08.01 winston_line): a
* step tap sent as flee_battle() returned, on the black's end, was lost;
* one more tap by hand stepped.
*
Expand All @@ -46,7 +46,7 @@ namespace MovementMechanics{
// Walking: a tile per 16 frames at 60 fps (console B, 2026-11-09).
inline constexpr Milliseconds TILE_TIME(267);
// Running with B held: a tile per 8 frames (console B, 2026-11-02, video
// of run 00.11).
// of run 04.01).
inline constexpr Milliseconds RUN_TILE_TIME(133);
// Surfing: a tile per 8 frames.
inline constexpr Milliseconds SURF_TILE_TIME(133);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ struct BikeTapCalls{
// game may miss a turn tap (MovementMechanics::MAX_TURN_TAPS).
constexpr int STEP_TAP_TRIES = 3;
// How far a sure start may be off before a blocked tap finds the player:
// three runs of 00.30 stood 3 tiles off (console B, 2026-11-09).
// three runs of 08.03 stood 3 tiles off (console B, 2026-11-09).
constexpr int BLOCKED_TAP_SLACK = 3;

// Walks the open leg `step` a tap at a time: on the Bicycle each tap is
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ ImageRGB32 periodic_floor(size_t scroll){
return image;
}

// Rocket Hideout B3F (00.32 run 1): a tap east over a floor that repeats
// Rocket Hideout B3F (09.02 run 1): a tap east over a floor that repeats
// every tile left the top band the same, so the tap read as a turn.
UnitTestResult test_scroll_over_periodic_floor(){
const ImageFloatBox game(0, 0, 1, 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ std::optional<Direction> read_facing(ConsoleHandle& console, ProControllerContex
// old way, and a leg's hold then spends its first 8 frames turning
// (pokefirered PlayerTurnInPlace(), a fast walk in place): a one-tile
// hold only turns the player, with nothing to show it (console B,
// 2026-11-09, 00.28 run 2: the step north onto Rock Tunnel B1F row 34).
// 2026-11-09, 08.01 run 2: the step north onto Rock Tunnel B1F row 34).
// A facing that can't be read is taken as turned: a tap while facing the
// way already would take a step.
void turn_to(ConsoleHandle& console, ProControllerContext& context, Direction direction);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,15 @@ std::string bound_text(const std::optional<WalkedTiles>& bound){
return bound ? std::format("{} to {}", bound->min, bound->max) : std::string("no bound");
}

// Console B, FRLG 00.27 run 2, 2026-11-09 (~/FRLGLab/captures/
// Console B, FRLG 07.02 run 2, 2026-11-09 (~/FRLGLab/captures/
// 2026-11-09-0027-route10-legs.log): on the open leg "east 11" across
// Route 10, wild battles (Voltorb) showed only after the hold. The walker
// took the player to be anywhere on the leg ("stopped 0 to 11 tiles in")
// and walked "east 12 (to wall)" to find them, into a second battle. Here
// the leg crosses Route 10's grass on row 10, the battle's flashes are
// missed, its text box ("Wild <Pokemon> appeared!") shows
// LATE_WILD_BATTLE_DELAY after its step and its HP boxes 800 ms after
// that, as in Mt. Moon (console B, 2026-11-03, row 00.13). After running,
// that, as in Mt. Moon (console B, 2026-11-03, row 04.05). After running,
// the walker must bound the player to a few tiles around the battle's.
class Test_OverworldLateBattle : public UnitTest{
public:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Overworld Maps Tests

Check warning on line 1 in SerialPrograms/Source/VideoGames/PokemonFRLG/Overworld/PokemonFRLG_OverworldMaps_Tests.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

<file>: file_lines=747 (advisory above 500, limit 1000)
*
* From: https://github.com/PokemonAutomation/
*
Expand Down Expand Up @@ -592,7 +592,7 @@
return true;
}

// 00.11's way from Pewter into Route 3 and 00.12's over Route 3 and 4.
// 04.01's way from Pewter into Route 3 and 04.02's over Route 3 and 4.
UnitTestResult test_found_again_route3_route4(){
const std::vector<MapData> maps = overworld_maps();
const UnitTestResult into_route3 = check_found_again(maps, {"PewterCity", {17, 26}}, {"Route3", {13, 8}});
Expand All @@ -618,7 +618,7 @@
};
const Case cases[] = {
{
.name = "Route 3, Lass Robin, east along row 9 (00.12)",
.name = "Route 3, Lass Robin, east along row 9 (04.02)",
.start = {"Route3", {36, 9}}, .direction = Direction::EAST, .tiles = 11, .to_wall = true,
.player = {"Route3", {40, 9}}, .trainer = {"Route3", {40, 10}},
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Overworld Recovery

Check warning on line 1 in SerialPrograms/Source/VideoGames/PokemonFRLG/Overworld/PokemonFRLG_OverworldRecovery.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

<file>: file_lines=609 (advisory above 500, limit 1000)
*
* From: https://github.com/PokemonAutomation/
*
Expand Down Expand Up @@ -63,7 +63,7 @@
// How far the holds that find the player after an open leg, and the way
// back, may walk, per tile of the leg. 2 left Rocket Hideout B3F's "west
// 7" off the stairs unchecked: the hold to its west wall and back walk up
// to 18, and the leg ended short (00.31 r1, console B, 2026-11-10). Route
// to 18, and the leg ended short (09.01 r1, console B, 2026-11-10). Route
// 1's "west 4", whose holds walk 30, stays unchecked.
constexpr int OPEN_LEG_CHECK_TILES_PER_TILE = 3;

Expand All @@ -87,7 +87,7 @@
// misses the arrow, or walks onto another, and ends elsewhere in the maze:
// "south 2" before Rocket Hideout B3F's "east 2" onto the arrow (3, 16)
// ended a tile short, the east leg walked into a wall, and the walk after
// it slid up to (10, 13) (00.31 r1 run 3, console B, 2026-11-10).
// it slid up to (10, 13) (09.01 r1 run 3, console B, 2026-11-10).
bool is_slide(const RouteStep& next){
return next.action == RouteAction::WALK && next.spin_tiles && !next.warps;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ constexpr double WALL_TAP_MOVED_RMSD = 20.0;
// How much a counted tap scrolled the map: the largest RMSD between `before`
// and `after` over the four edge quarters (top, bottom, left, right) of
// `game`, all clear of the player in the middle. One band alone misses a
// step over a floor that repeats every tile (Rocket Hideout B3F, 00.32): a
// step over a floor that repeats every tile (Rocket Hideout B3F, 09.02): a
// one-tile scroll leaves the band nearly the same.
double tap_scroll_change(const ImageViewRGB32& before, const ImageViewRGB32& after, const ImageFloatBox& game);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ struct RouteStep{
// WALK on foot: walked a tap at a time, each a tile, and each checked
// to have moved (count_step_taps()), as through the hideout's arrow
// floors, where a hold that ends a tile off slides the player
// elsewhere (console B, 2026-11-10, 00.31 r1).
// elsewhere (console B, 2026-11-10, 09.01 r1).
bool tapped = false;
// WALK, SURF: a wild Pokemon can appear on the way: the step crosses
// tall grass or water. Elsewhere (indoors, streets) no wild battle can
Expand All @@ -72,13 +72,13 @@ struct RouteStep{
// WALK: the steps (from 1) onto a connected map. The game holds the
// player up a tile before each while it loads the map: a hold timed
// by the tiles alone ended a tile short (console B, 2026-11-03, rows
// 00.14, 00.16 and 00.20).
// 04.06, 05.05 and 05.09).
std::vector<int> connection_steps = {};
// WALK onto a warp: how many tiles further the player may stand from
// it than planned, which the hold goes on for, stopping at the fade.
// An open leg over a map connection before it may end a tile further
// on, when the game doesn't hold the player up there (console B,
// 2026-11-03, row 00.24). Set by with_warp_slack() when a route runs.
// 2026-11-03, row 06.03). Set by with_warp_slack() when a route runs.
int warp_slack = 0;
// Which way the player faces after the step. Arriving at a door or a
// cave mouth, the game walks the player a tile out, facing south.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Overworld Sim

Check warning on line 1 in SerialPrograms/Source/VideoGames/PokemonFRLG/Overworld/PokemonFRLG_OverworldSim.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

<file>: file_lines=994 (advisory above 500, limit 1000)
*
* From: https://github.com/PokemonAutomation/
*
Expand Down Expand Up @@ -499,7 +499,7 @@
if (m_script.connections_stall && step->map != m_map && !step->warped){
// The step onto a connected map waits a tile while the game
// loads it: a hold timed by its tiles alone ended a tile short
// (console B, 2026-11-03, rows 00.14, 00.16 and 00.20).
// (console B, 2026-11-03, rows 04.06, 05.05 and 05.09).
pressed += tile;
if (pressed >= end){
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -251,20 +251,20 @@ struct SimWalkerRules{
// A leg onto a warp whose fade was a wild battle's (its wipe passes for
// the fade) stops before the warp, and the player is found again on it.
// Without it the walker stopped as off the route (console B,
// 2026-11-03, Mt. Moon 1F, row 00.13).
// 2026-11-03, Mt. Moon 1F, row 04.05).
bool find_player_after_warp_battle = true;
// After a leg's watch saw nothing, a battle's text box on screen (its
// HP boxes still to come) is watched on for, and the leg taken as
// stopped part-way. Without it the walker took "south 15 (to wall)"
// as walked and the next leg into the battle (console B, 2026-11-03,
// Mt. Moon B1F, row 00.13).
// Mt. Moon B1F, row 04.05).
bool watch_on_for_unseen_battle = true;
// The same after a leg the maps see no wild tiles on (RouteStep::wild),
// which the leg and its watch don't watch for battles: on Mt. Moon
// B2F's tiles closed on one side, which the maps don't mark as wild, a
// battle on "east 7 (to wall)" left black after the leg, the leg was
// taken as walked and the next one held from where the battle was
// (console B, 2026-11-03, row 00.13).
// (console B, 2026-11-03, row 04.05).
bool watch_on_after_unmarked_leg = true;
// Before a step, a battle on its way (its text box or wipe) is watched
// on for, and the step before it taken as stopped part-way, not the
Expand All @@ -273,29 +273,29 @@ struct SimWalkerRules{
// A hold over a step onto a connected map is a tile longer for it
// (RouteStep::connection_steps). Without it the open leg north from
// Cerulean City onto Nugget Bridge ended a tile short (console B,
// 2026-11-03, rows 00.16 and 00.20).
// 2026-11-03, rows 05.05 and 05.09).
bool hold_over_connections = true;
// An open leg after whose hold a wild battle was seen is placed by the
// battle's first timed screen event (place_late_stop()). Without it the
// player may be anywhere on the leg: on Route 10, "east 11" was found
// again from all 12 of its tiles (console B, 2026-11-09, 00.27 run 2).
// again from all 12 of its tiles (console B, 2026-11-09, 07.02 run 2).
bool place_late_battle = true;
// The watch for a warp's fade starts with the hold onto the warp
// (Pokemon::WatchAlong), not when it ends. Without it a fade over
// before the hold ended was missed, and the walk stopped on "no fade in
// and out after walking onto the warp" though it had warped (console B,
// 2026-11-09 01:41, 00.27, the warp to CeruleanCity: the watch started
// 2026-11-09 01:41, 07.02, the warp to CeruleanCity: the watch started
// about 1.3 s into the hold).
bool watch_fade_along_hold = true;
// A warp's fade is taken as the warp only once the screen after it
// shows the player off the map they held from (warp_left_scene()).
// Without it a black that cleared with the player where they were was
// taken as the warp (console B, 2026-11-10 01:44, 00.31 run 4).
// taken as the warp (console B, 2026-11-10 01:44, 09.01 run 4).
bool confirm_warp_destination = true;
// A turn tap is checked by the facing on screen, and tapped again
// while the player faces another way (OverworldWalkSteps::turn_to()).
// Without it a dropped tap left a one-tile leg turning the player
// only, taken as walked (console B, 2026-11-09, 00.28 run 2).
// only, taken as walked (console B, 2026-11-09, 08.01 run 2).
bool confirm_turn = true;
// The speed the walker goes at: its turn taps
// (OverworldWalkSteps::turns_first()) and its holds' tile time.
Expand All @@ -304,7 +304,7 @@ struct SimWalkerRules{
// tile (count_bike_taps()), and one that doesn't move finds the player
// ahead of a block. Without it the leg is one hold, and a start off
// along the leg ends it off with nothing to show it (console B,
// 2026-11-09, 00.30: three runs 3 tiles east after Route 8's legs).
// 2026-11-09, 08.03: three runs 3 tiles east after Route 8's legs).
bool count_bike_taps = true;
// How far apart, start to start, the counted taps are
// (MovementMechanics::BIKE_TAP_PERIOD).
Expand All @@ -316,14 +316,14 @@ struct SimWalkerRules{
// A dark cave's overworld isn't a battle on its way
// (OverworldWalkSteps::dark_cave_screen()). Without it the check
// before each step watched for a battle on it (console B, 2026-11-09,
// 00.28: "running from a wild Pokemon", then "not a battle").
// 08.01: "running from a wild Pokemon", then "not a battle").
bool dark_cave_not_battle = true;
// A stop on an open leg that started in a dark cave may be anywhere on
// the leg (whole_leg()). Without it the stop is placed by the dark
// screen's black, read as the battle at the hold's start: a battle at
// the end of "east 12" on Rock Tunnel B1F was placed 0 to 3 tiles in,
// and the player was found again at a wall 5 tiles off (console B,
// 2026-11-09, 00.28).
// 2026-11-09, 08.01).
bool whole_leg_in_dark = true;
// The end of a trainer's battle the walker fought, as the story's
// battle loop takes it on the screen the sim shows after it: its
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ struct SimScript{
std::set<std::string> wild_floor_maps;
// Whether the game holds the player up a tile on a step onto a
// connected map. It did north onto Nugget Bridge (console B,
// 2026-11-03, rows 00.16 and 00.20), not south from Route 6 into
// Vermilion City (row 00.24).
// 2026-11-03, rows 05.05 and 05.09), not south from Route 6 into
// Vermilion City (row 06.03).
bool connections_stall = true;
// Wild battles at the game's own odds instead of `encounters`, on the
// maps named here, with their land encounter rate (pokefirered
Expand All @@ -52,18 +52,18 @@ struct SimScript{
// the game misses, by number from 1; the player goes on facing the old
// way. The game drops none from a standstill (MovementMechanics: 70 of
// 70 turned); these test the walker's check of the turn
// (SimWalkerRules::confirm_turn) after 00.28 run 2 (console B,
// (SimWalkerRules::confirm_turn) after 08.01 run 2 (console B,
// 2026-11-09), where a one-tile leg only turned the player.
std::set<int> dropped_turn_taps;
// Fault injection: steps onto a warp, by number from 1, that show the
// fade's black and clear with the player where they were, not warped
// (console B, 2026-11-10 01:44, 00.31 run 4, "east 1 (warp)" on B4F).
// (console B, 2026-11-10 01:44, 09.01 run 4, "east 1 (warp)" on B4F).
std::set<int> black_without_warp;
// The player rides the Bicycle: a tap facing another way takes a step
// too, a hold through a turn loses no tile
// (MovementMechanics::BIKE_TAP_ONLY_TURNS), and no step tap is
// ignored: a 40ms turn tap and a 56ms hold 340ms after it took two
// tiles (console B, 2026-11-09, 00.30). At the start: SELECT gets on
// tiles (console B, 2026-11-09, 08.03). At the start: SELECT gets on
// and off (OverworldSim::press_select()), a warp gets off. Each tap is
// a tile; one in MovementMechanics::BIKE_FAST_TAP_DROP_EVERY of those
// that start sooner than BIKE_TAP_DROP_PERIOD after the last is
Expand All @@ -75,7 +75,7 @@ struct SimScript{
// Caves dark without Flash (Rock Tunnel): the overworld is black but
// for a lit circle on the player, which the walker's battle text box
// check and screen observer read as a battle on its way (console B,
// 2026-11-09, 00.28), unless SimWalkerRules::dark_cave_not_battle.
// 2026-11-09, 08.01), unless SimWalkerRules::dark_cave_not_battle.
std::set<std::string> dark_maps;
// A lift's map, and where its door lets the player out for each floor
// on its panel's menu, top first (pokefirered setdynamicwarp in
Expand Down
Loading
Loading