Repository navigation
PokemonBDSP AutoStory: town plans keep straight open runs to one leg - #383
Merged
Merged
Conversation
…d kids Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Open legs run together in one direction were tapped as one walk: "north 20 (open)" to Jubilife's Center ended about 4 tiles short on lab-B (2026-11-11). Town costs now cap a straight run of open legs at max_open_tiles, so a long stretch meets a wall on the way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Every story ROUTE step whose start the table knows is walked on the simulated console from each start tile, once as planned and once with every open leg of n tiles stopping min(4, n / 4) tiles early, unseen (lab-B 2026-11-11: "north 20 (open)" ended about 4 short). The sim no longer counts arrive()'s banner pauses as walker calls. Red: 31 of 62 routes end off their target with the fault (33 on #374). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Console measurement (lab-B 2026-11-11, Jubilife): D-pad taps are tile-exact (5, 10, 15 and 20 taps, each moved a tile) and stick runs timed for 10 tiles overshot by about 3, three of three; none came up short. The sim's open legs are taps and so exact; a timed stick hold now goes 0..ceil(0.35 n) tiles further until a wall stops it. The walker taps every open leg, so no story route sees the fault. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The cap answered "north 20 (open)" ending 4 tiles short on lab-B. The console measurement since (2026-11-11, Jubilife) shows D-pad taps are tile-exact; that walk was a timed hold, which overshoots. This walker taps every open leg, and the story-route fault sweep passes 62 of 62 with and without the cap, which only made routes longer (00.05b company clown 27 -> 35, 00.05c president 48 -> 54, 01.06 102 -> 124). This reverts commit 18304df. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s overshooting lab-B 2026-11-11 13:38: "north 20 (open)" walked as a held run overshot and the walk ended far from the Center. The simulated console now times a hold to a limit and, with the fault on, goes up to ceil(0.35 n) tiles past it until a wall stops it. From (48, 62) the walk with every timed hold overshooting must still end on (52, 41); this walker taps open legs, so it does. It replaces the open-leg cap test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #379
On lab-B (2026-11-11) "north 20 (open)" to Jubilife's Center was walked as a held run and overshot; measured since, D-pad taps are tile-exact and held runs overshoot about 3 tiles per 10 (none came up short). This PR adds a story-route fault sweep in the PlannedRoute tests: every story ROUTE walked on the simulated console, once as planned and once with every timed hold going 0..ceil(0.35 n) tiles too far until a wall stops it, plus a Jubilife case from (48, 62) under that fault. This walker taps every open leg (holds only to a wall), so all 62 routes pass with and without the fault, same as on #374; the held-leg walker on bdsp/sim is what the Jubilife case would catch. The 12-tile open-run cap added earlier here is reverted: it changed no outcome and only made routes longer.
Tested with the PokemonBDSP AutoStory suites via SerialProgramsTests (with #392 merged for the plan golden): all pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss