Skip to content

FRLG AutoStory: confirm the warp of a step onto a door or stairs; warp no-op sweep - #394

Merged
dayfine merged 2 commits into
frlg/stage8-rocktunnelfrom
frlg/warp-confirm
Nov 11, 2026
Merged

dayfine merged 2 commits into
frlg/stage8-rocktunnelfrom
frlg/warp-confirm

Conversation

@dayfine

@dayfine dayfine commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Depends on #293

A plain story step onto a door, exit mat or stairs (e.g. 02.01's mart_door) was counted as done straight after the tap, with no check that the game warped; route legs already confirm the fade and the new scene since the 09.01 B4F fix. Now such a step goes through wait_out_warp() (fade, two retry taps, then the scene-left check) and stops if the warp never happens; the row sim mirrors it. A new "warp no-op" fault class makes every warp on one map do nothing (SimScript::dead_warp_maps), for each map a row warps from, and requires the row to stop at that step: before the fix 02.01 went on into the Mart as if warped, after it every row passes. Tested with the FRLG suites in SerialProgramsTests (fault sweeps, golden plans byte-identical, overworld sim); only the known AutoStoryResources gap and fork-only image FileExceptions fail. BDSP needs the same check for its door/stairs steps and the same sweep; not touched here.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 2 commits November 11, 2026 13:39
…irmed

A plain STEP onto a door, mat or stairs was taken as walked with no check
that the game warped. It now waits out the fade and checks the screen left
the scene (wait_out_warp()), and the row sim does the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine merged commit f854dee into frlg/stage8-rocktunnel Nov 11, 2026
15 checks passed
@dayfine
dayfine deleted the frlg/warp-confirm branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant