Repository navigation
FRLG AutoStory: confirm the warp of a step onto a door or stairs; warp no-op sweep - #394
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…irmed A plain STEP onto a door, mat or stairs was taken as walked with no check that the game warped. It now waits out the fade and checks the screen left the scene (wait_out_warp()), and the row sim does the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #293
A plain story step onto a door, exit mat or stairs (e.g. 02.01's
mart_door) was counted as done straight after the tap, with no check that the game warped; route legs already confirm the fade and the new scene since the 09.01 B4F fix. Now such a step goes throughwait_out_warp()(fade, two retry taps, then the scene-left check) and stops if the warp never happens; the row sim mirrors it. A new "warp no-op" fault class makes every warp on one map do nothing (SimScript::dead_warp_maps), for each map a row warps from, and requires the row to stop at that step: before the fix 02.01 went on into the Mart as if warped, after it every row passes. Tested with the FRLG suites in SerialProgramsTests (fault sweeps, golden plans byte-identical, overworld sim); only the known AutoStoryResources gap and fork-only image FileExceptions fail. BDSP needs the same check for its door/stairs steps and the same sweep; not touched here.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss